Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to unpoller #255

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Updates to unpoller #255

merged 1 commit into from
Apr 1, 2024

Conversation

chrisbsmith
Copy link
Owner

No description provided.

Copy link

github-actions bot commented Apr 1, 2024

--- kubernetes/apps/monitoring/unpoller/app Kustomization: flux-system/unpoller HelmRelease: monitoring/unpoller

+++ kubernetes/apps/monitoring/unpoller/app Kustomization: flux-system/unpoller HelmRelease: monitoring/unpoller

@@ -14,23 +14,26 @@

       chart: app-template
       sourceRef:
         kind: HelmRepository
         name: bjw-s
         namespace: flux-system
       version: 3.0.4
+  dependsOn:
+  - name: kube-prometheus-stack
+    namespace: monitoring
   install:
     remediation:
       retries: 3
   interval: 30m
-  maxHistory: 2
   uninstall:
     keepHistory: false
   upgrade:
     cleanupOnFail: true
     remediation:
       retries: 3
+      strategy: rollback
   values:
     controllers:
       unpoller:
         containers:
           app:
             env:
@@ -39,18 +42,23 @@

             envFrom:
             - secretRef:
                 name: unpoller-secret
             image:
               repository: ghcr.io/unpoller/unpoller
               tag: v2.10.0
+            probes:
+              liveness:
+                enabled: true
+              readiness:
+                enabled: true
             resources:
               limits:
-                memory: 128M
+                memory: 128Mi
               requests:
-                cpu: 5m
-                memory: 36M
+                cpu: 10m
+                memory: 36Mi
             securityContext:
               allowPrivilegeEscalation: false
               capabilities:
                 drop:
                 - ALL
               readOnlyRootFilesystem: true
@@ -64,13 +72,12 @@

         controller: unpoller
         ports:
           http:
             port: 9130
     serviceMonitor:
       app:
-        enabled: true
         endpoints:
         - interval: 2m
           path: /metrics
           port: http
           scheme: http
           scrapeTimeout: 10s

Copy link

github-actions bot commented Apr 1, 2024

--- HelmRelease: monitoring/unpoller Deployment: monitoring/unpoller

+++ HelmRelease: monitoring/unpoller Deployment: monitoring/unpoller

@@ -43,19 +43,33 @@

         - name: UP_INFLUXDB_DISABLE
           value: 'true'
         envFrom:
         - secretRef:
             name: unpoller-secret
         image: ghcr.io/unpoller/unpoller:v2.10.0
+        livenessProbe:
+          failureThreshold: 3
+          initialDelaySeconds: 0
+          periodSeconds: 10
+          tcpSocket:
+            port: 9130
+          timeoutSeconds: 1
         name: app
+        readinessProbe:
+          failureThreshold: 3
+          initialDelaySeconds: 0
+          periodSeconds: 10
+          tcpSocket:
+            port: 9130
+          timeoutSeconds: 1
         resources:
           limits:
-            memory: 128M
+            memory: 128Mi
           requests:
-            cpu: 5m
-            memory: 36M
+            cpu: 10m
+            memory: 36Mi
         securityContext:
           allowPrivilegeEscalation: false
           capabilities:
             drop:
             - ALL
           readOnlyRootFilesystem: true

@chrisbsmith chrisbsmith merged commit 3997de5 into main Apr 1, 2024
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-unpoller branch April 1, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant