Fix for styled space being removed #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbottin
approved these changes
Oct 23, 2023
|
@RobertLevett the tests are failing, can you take a look? |
chrisbottin
reviewed
Oct 23, 2023
| @@ -134,5 +134,9 @@ describe('XML formatter', function () { | |||
| context('should collapse empty tags when forceSelfClosingEmptyTag=true', function () { | |||
| assertFormat('test/data15/xml*-input.xml', { forceSelfClosingEmptyTag: true }); | |||
| }); | |||
|
|
|||
| context('should not remove space with style before differently stylised word when prettifying xml', function () { | |||
There was a problem hiding this comment.
@RobertLevett can you move the files from data16 to data12 folder? We already have the same configuration to format using the same option {collapseContent: true}
There was a problem hiding this comment.
Will do, just looking at test now too
RobertLevett
force-pushed
the
origin/fix-for-missing-space
branch
from
66fb1d7
to
00a149f
Compare
Fix for styled space being trimmed when the following word is styled differently, even when within a preserved parent.
|
Thanks @RobertLevett for your contribution. The fix has been published with version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for styled space being trimmed when the following word is styled differently, even when within a preserved parent.