Skip to content

Commit

Permalink
ios build: Address two Xcode deprecation warnings.
Browse files Browse the repository at this point in the history
Part of the RN v0.61 -> v0.62 changes to the template app [1],
corresponding to facebook/react-native@ebb629d05. These are warnings
I think we've seen for a while (zulip#4112), and there's no suggestion
that we can't do them before the main upgrade commit.

The diff in the RN commit seems to address two warnings at the same
time, even though only the "Missing Localizability" one is
mentioned; like in that commit, we do them both here.

They are:

"""
Migrate "English.lproj" (Deprecated)

Migrating the English, deprecated localization to English is
recommended for all projects. This will ensure localized resources
are placed in “en.lproj” directories instead of deprecated
“English.lproj” directories.
"""

"""
Turn on "Missing Localizability"

This will turn on the static analyzer check for "Missing
Localizability", because this project is localized for multiple
languages.
"""

The "Missing Localizability" change appears in the Upgrade Support
repo's official guide for how to change the Xcode files using
Xcode [2]; the "Migrate 'english.lproj' (Deprecated)" one does not.

See also discussion on GitHub [3].

[1] https://react-native-community.github.io/upgrade-helper/?from=0.61.5&to=0.62.2
[2] react-native-community/upgrade-support#13
[3] zulip#4244 (comment)
  • Loading branch information
chrisbobbe committed Sep 11, 2020
1 parent cc51ea2 commit 1ebd4d4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions ios/ZulipMobile.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
83CBB9F71A601CBA00E9B192 /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 940;
LastUpgradeCheck = 1160;
TargetAttributes = {
13B07F861A680F5B00A75B9A = {
DevelopmentTeam = 66KHCWMEYB;
Expand All @@ -194,10 +194,9 @@
};
buildConfigurationList = 83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "ZulipMobile" */;
compatibilityVersion = "Xcode 3.2";
developmentRegion = English;
developmentRegion = en;
hasScannedForEncodings = 0;
knownRegions = (
English,
en,
Base,
);
Expand Down Expand Up @@ -447,6 +446,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
Expand Down Expand Up @@ -502,6 +502,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0940"
LastUpgradeVersion = "1160"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "0940"
LastUpgradeVersion = "1160"
version = "1.3">
<BuildAction
parallelizeBuildables = "YES"
Expand Down

0 comments on commit 1ebd4d4

Please sign in to comment.