Add a function to create a Source from a unique id. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows you to start listenting to the device even if it's not currently plugged in.
chris-zen
reviewed
Jun 30, 2024
… Sources::from_unique_id use it. Updated documentation and cleaned up code.
|
Thanks @akhudek !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to create a source from a unique id. The advantage of this over using name or index is that the unique id is unique to the device, even if more than one of the same device is plugged in, and it persists across reboots and device disconnects.
Also, this allows you to create a source for a device even if it's not currently plugged in. In my testing MacOS will automatically start sending midi messages to your listener once the device is plugged in.