Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log filter issue with mkdocs >= 1.2 #45

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix log filter issue with mkdocs >= 1.2 #45

merged 1 commit into from
Nov 20, 2023

Conversation

hbokh
Copy link
Contributor

@hbokh hbokh commented Aug 29, 2023

This is basically a copy & paste fix from

fralau/mkdocs-macros-plugin#173

It is meant to get rid of this (annoying) deprecation warning:

$ mkdocs build --strict
INFO    -  DeprecationWarning: warning_filter doesn't do anything since MkDocs 1.2 and will be removed soon. All messages on the `mkdocs` logger get counted automatically.
  File "/usr/local/lib/python3.11/site-packages/mkdocs_exclude_search/plugin.py", line 9, in <module>
    from mkdocs.utils import warning_filter

Frankencode... but tested OK with mkdocs==1.5.2.

@hbokh
Copy link
Contributor Author

hbokh commented Oct 30, 2023

Hi @chrieke !
Any update on this PR?

FYI I use / include my feature branch like this without issue:

$ cat -p requirements.txt
mkdocs==1.5.3
mkdocs-autolinks-plugin==0.7.1
mkdocs-awesome-pages-plugin==2.9.2
mkdocs-exclude-search @ git+https://github.com/hbokh/mkdocs-exclude-search.git@85bf35d2c2a0f6e712779d9e7593ffd976b7a6f4
mkdocs-git-revision-date-localized-plugin==1.2.1
mkdocs-material==9.4.7
mkdocs-minify-plugin==0.7.1
pymdown-extensions==10.3.1

@chrieke
Copy link
Owner

chrieke commented Nov 20, 2023

Thanks for the ping and the PR! Very nice. Will integrate and push a new version soon, will ping here.

@chrieke chrieke merged commit 7bbd395 into chrieke:main Nov 20, 2023
@chrieke chrieke mentioned this pull request Nov 20, 2023
@mdmintz
Copy link

mdmintz commented Nov 29, 2023

Hello, and thank you for your work. The latest version on PyPI is still 0.6.5:
(https://pypi.org/project/mkdocs-exclude-search/)

Screenshot 2023-11-29 at 8 39 39 AM

Are there any plans to deploy 0.6.6 to there in the near future?

@hbokh
Copy link
Contributor Author

hbokh commented Nov 29, 2023

Ping @chrieke ☝🏻

@chrieke
Copy link
Owner

chrieke commented Dec 3, 2023

@mdmintz @hbokh Released on Pypi now, forgot that. Thanks for the ping.

@hbokh hbokh deleted the feature/fix-log-filter-issue branch December 4, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants