Add Openstack related changes to Rouster. #79
Conversation
| @@ -39,7 +39,7 @@ but no real testing has been done to confirm this. Please file issues as appropr | |||
| ```sh | |||
| git clone https://github.com/chorankates/rouster.git | |||
| cd rouster | |||
| bundle install # use :aws to pull in fog | |||
| bundle install # use :aws or :openstack to pull in fog | |||
There was a problem hiding this comment.
this won't work unless you add an additional block in the Gemfile, which i don't recommend.
it might make more sense to add something related to line 32 above
|
|
||
| [:openstack_auth_url, :openstack_username, :openstack_tenant, :openstack_api_key, | ||
| :key ].each do |r| | ||
| raise ArgumentError.new(sprintf('Openstack passthrough requires %s specification', r)) if @passthrough[r].nil? |
There was a problem hiding this comment.
think this is the last one.. for consistency, can you change this to 'OpenStack'?
|
caught a number of test failures/errors when running
while trying to look into the cause, i noticed that you're also using tabs, not 2 spaces. please fix the tests and the spacing |
…e statement. Replaced tabs with spaces
|
I have refreshed the PR with a fix for the failed tests. I have also Thanks, On Wed, Sep 9, 2015 at 11:44 AM, Conor Horan-Kates <[email protected]
|
Add Openstack related changes to Rouster.
This PR contains code changes to enable bring up and shut down of OpenStack instances via Rouster. In particular, the following OpenStack specific methods are being added:
ostack_connect
ostack_describe_instance
ostack_destroy
ostack_get_instance_id
ostack_get_ip
ostack_status
ostack_up