fixing a minor bug ('Sun' in RHEL6u5 uname -a output was throwing us …

…off), adding TODO about proper future handling
chorankates · Dec 6, 2013 · a4e8362 · a4e8362
1 parent afa6ceb
commit a4e8362
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/rouster.rb b/lib/rouster.rb
@@ -360,13 +360,19 @@ def os_type
       return @ostype
     end
 
+    # TODO switch to file based detection
+    # Ubuntu - /etc/os-release
+    # Solaris - /etc/release
+    # RHEL/CentOS - /etc/redhat-release
+    # OSX - ?
+
     res   = nil
     uname = self.run('uname -a')
 
     case uname
       when /Darwin/i
         res = :osx
-      when /Sun|Solaris/i
+      when /SunOS|Solaris/i
         res =:solaris
       when /Ubuntu/i
         res = :ubuntu