Add config option for hiding/filtering stats table #731
Conversation
| parse: function(resp, options) { | ||
| base.Collection.prototype.parse.call(this, resp, options); | ||
|
|
||
| var statsConfig = c.config.get('statsModelsList'), |
There was a problem hiding this comment.
This would be better suited as an option to the CountCollection class. The statsModelsList (better named modelCountList?) is more of a convenience for passing it as an option to the rendered on the workspace.
There was a problem hiding this comment.
I'm unclear as to how to get this option passed to the CountCollection class as the initial model is automatically created here and I'm not seeing a good way to include the option in the stats creation in order to pass it to the CountCollection. I could remove this filtering from the model altogether and move the filtering to the stats.CountList view and pass the option into that view.
There was a problem hiding this comment.
The last option makes the most sense to me. The view should pass the options to customize what is being rendered on not. That way multiple views can reuse the same data (the collection in this case) and present in various ways.
|
@naegelyd Thanks for working on this. In the scenario in which the statsModelsList is disabled entirely, it would be best to restore the original formatting such that the public queries are listed in a separate column on the right. |
Signed-off-by: Don Naegely <[email protected]>
Add config option for hiding/filtering stats table
Fix #730.
Putting this in but definitely looking for feedback on the approach.
Signed-off-by: Don Naegely [email protected]