Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Allow negation/exclusion for searchable fields #726

Merged
merged 2 commits into from
Oct 14, 2014
Merged

Allow negation/exclusion for searchable fields #726

merged 2 commits into from
Oct 14, 2014

Conversation

naegelyd
Copy link
Collaborator

Fix #678.

Signed-off-by: Don Naegely [email protected]

@bruth
Copy link
Contributor

bruth commented Oct 14, 2014

Can you post a screenshot?

@naegelyd
Copy link
Collaborator Author

Sure, here it is. Definitely open to change how this looks just wanted to get this in there and start the conversation.

screen shot 2014-10-14 at 2 13 23 pm

@bruth
Copy link
Contributor

bruth commented Oct 14, 2014

I think the text and checkbox would look more natural above the textarea. Likewise, I think the "Clear" button would look better there as well.

@murphyke
Copy link
Member

+1 for this control and the Clear button above the textarea

@naegelyd
Copy link
Collaborator Author

Now it looks like this:

screen shot 2014-10-14 at 3 02 37 pm

@bruth
Copy link
Contributor

bruth commented Oct 14, 2014

Looks good. Much more clear in my opinion.

On Tue, Oct 14, 2014 at 3:04 PM, Don Naegely [email protected]
wrote:

Now it looks like this:

screen shot 2014-10-14 at 3 02 37 pm

Reply to this email directly or view it on GitHub:
#726 (comment)

bruth added a commit that referenced this pull request Oct 14, 2014
Allow negation/exclusion for searchable fields
@bruth bruth merged commit bd45a47 into master Oct 14, 2014
@bruth bruth deleted the issue-678 branch October 14, 2014 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow negation/exclusion for searchable fields
3 participants