This repository has been archived by the owner on May 11, 2021. It is now read-only.
Fix unstable event handler in workspace affecting save columns button #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tton This was an issue of where the event handler was initialized in the workspace workflow. Formerly, the event handler was initialized in the initialize method but the ui elements aren't initialized yet at that point so we were trying to call 'show()' on a string(because ui elements are string still during initialize). By setting the event handler in onRender we can be sure that the ui elements have been initialized and the event handler will be valid. Signed-off-by: Don Naegely <[email protected]>
naegelyd
added a commit
that referenced
this pull request
Oct 7, 2014
Fix unstable event handler in workspace affecting save columns button
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #710.
This was an issue of where the event handler was initialized in the
workspace workflow. Formerly, the event handler was initialized in the
initialize method but the ui elements aren't initialized yet at that
point so we were trying to call 'show()' on a string(because ui elements
are string still during initialize). By setting the event handler in
onRender we can be sure that the ui elements have been initialized and
the event handler will be valid.
Signed-off-by: Don Naegely [email protected]