Whitespacer #81
Merged
Whitespacer #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantoni
reviewed
Jun 26, 2017
browser.js
Outdated
| if (i === 0) { | ||
| value = lastChild.nodeValue.replace(leadingNewlineRegex, '') | ||
| } else { | ||
| value = lastChild.nodeValue.replace(leadingNewlineRegex, ' ') |
There was a problem hiding this comment.
You could combine the above cases like this:
var leader = i === 0 ? '' : ' '
value = lastChild.nodeValue.replace(leadingNewlineRegex, leader)
This was referenced Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes whitespace issues in text nodes, introduced in #74. Includes tests from #77.
Paves the way to fix shama/yo-yoify#48.
The algorithm is now aware of the sibling, and parent nodes of all text nodes and tries to collapse whitespace based on that. It respects
<pre>and<code>blocks too, leaving whitespace as-is for those.The code is rather complicated I feel, but this fixes the issue. If anyone wants to take a stab at a refactor / introduce more test cases that'd be grand. Thanks!