Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "strip empty text nodes (#68)", fixes #72 #73

Closed
wants to merge 1 commit into from

Conversation

goto-bus-stop
Copy link
Member

The empty text node between elements is significant in cases like these, where both span and strong are inline elements:

require('bel')`
  <div>
    <span>Hello</span>
    <strong>${username}</strong>
  </div>
`

They're not significant if an element on either side of the text node is a block-level element, but I don't think that case can be detected easily and reliably

@yoshuawuyts
Copy link
Member

Trying to fix it in #74 - if we can't fix it we should indeed roll back. Thanks for the patch anyhow! 😁

@yoshuawuyts
Copy link
Member

Unpublished [email protected] - closing in favor of #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants