Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store realNode reference on proxy node #75

Merged
merged 5 commits into from
Mar 3, 2018
Merged

Store realNode reference on proxy node #75

merged 5 commits into from
Mar 3, 2018

Conversation

kristoferjoseph
Copy link

@kristoferjoseph kristoferjoseph commented Mar 2, 2018 •
edited by bcomnes
Loading

Needs the other half in nanomorph#98 to land first.

Adds real node reference and test.

Depends on choojs/nanomorph#98

@kristoferjoseph
Copy link
Author

Tests are failing currently. Awaiting nanomorph PR merge.

bcomnes
bcomnes requested changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@bcomnes bcomnes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the package-lock.json. Will mull this over 4 real sometimes real soon

@bcomnes bcomnes mentioned this pull request Mar 2, 2018
Merged
@bcomnes
Copy link
Contributor

bcomnes commented Mar 3, 2018

Looks good to me. Will approve when green.

@bcomnes bcomnes changed the base branch from master to beta March 3, 2018 04:43
@bcomnes bcomnes changed the title Issue 65 Store realNode reference on proxy node Mar 3, 2018
@bcomnes
Copy link
Contributor

bcomnes commented Mar 3, 2018

I'm going to do the same thing, and release a beta version.

@kristoferjoseph kristoferjoseph mentioned this pull request Mar 3, 2018
Merged
@bcomnes bcomnes merged commit 0e02a3a into beta Mar 3, 2018
@bcomnes bcomnes deleted the issue-65 branch March 3, 2018 04:50
@bcomnes
Copy link
Contributor

bcomnes commented Mar 3, 2018

🎉[email protected]🎉

$ npm i nanocomponent@beta --save

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcomnes bcomnes bcomnes approved these changes

@toddself toddself Awaiting requested review from toddself

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristoferjoseph @bcomnes