-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write tests #11
Comments
@yoshuawuyts do you need a hand with this? I'm trying to get my head around how to fit |
@joshgillies oh man, having help writing tests would be amazing! - I agree this is critical; it's bitten us on Dat Desktop too (hence the super ad-hoc patches). For tests I was thinking a combination of tape for Node testing and tape-run for browser testing. Think testing both would be most resilient b/c choo apps tend to be used in both scenarios - reckon that'd work for ya? ✨ |
Hey, haven't forgot about this. As you can tell I've been kicking the tires here a bit over the last few weeks. I think the above approach to testing is sound. Lets aim to run up a branch + PR and iterate on tests there! 🎉 |
Yeah sounds good!
…On Thu, Mar 16, 2017 at 2:52 AM Josh Gillies ***@***.***> wrote:
Hey, haven't forgot about this. As you can tell I've been kicking the
tires here a bit over the last few weeks. I think the above approach to
testing is sound. Lets aim to run up a branch + PR and iterate on tests
there! 🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWlelgwKzK03kkBEkSoAw7kIwBSA0qEks5rmJXbgaJpZM4MGLcE>
.
|
Welll, the example mostly covers it - given we have so few lines of code I think bugs are hard to sneak in. Closing C: |
Too much stuff is failing, we need to make sure this lib works as intended
The text was updated successfully, but these errors were encountered: