Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write tests #11

Closed
yoshuawuyts opened this issue Feb 20, 2017 · 5 comments
Closed

write tests #11

yoshuawuyts opened this issue Feb 20, 2017 · 5 comments
Assignees

Comments

@yoshuawuyts
Copy link
Member

Too much stuff is failing, we need to make sure this lib works as intended

@joshgillies
Copy link
Contributor

@yoshuawuyts do you need a hand with this? I'm trying to get my head around how to fit nanocomponents into our workflow, so knowing the interface is sound would be of great benefit. 👍

@yoshuawuyts
Copy link
Member Author

@joshgillies oh man, having help writing tests would be amazing! - I agree this is critical; it's bitten us on Dat Desktop too (hence the super ad-hoc patches).

For tests I was thinking a combination of tape for Node testing and tape-run for browser testing. Think testing both would be most resilient b/c choo apps tend to be used in both scenarios - reckon that'd work for ya? ✨

@joshgillies
Copy link
Contributor

Hey, haven't forgot about this. As you can tell I've been kicking the tires here a bit over the last few weeks. I think the above approach to testing is sound. Lets aim to run up a branch + PR and iterate on tests there! 🎉

@yoshuawuyts
Copy link
Member Author

yoshuawuyts commented Mar 16, 2017 via email

@yoshuawuyts
Copy link
Member Author

Welll, the example mostly covers it - given we have so few lines of code I think bugs are hard to sneak in. Closing C:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants