Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add CODEOWNERS files #3475

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jul 2, 2024

Description Of Changes

Add CODEOWNERS file, so that we can track future changes to files.

Motivation and Context

This is an attempt to ensure that any changes to our dependencies, whether that is:

  • changes to NuGet packages through packages.config files
  • updates to custom assemblies which are not tracked through NuGet packages
  • updates to custom executables/assemblies which are added directly to the Chocolatey CLI Chocolatey Packages

Are tracked and updated properly. By making these files/folder owned by the new @chocolatey-credits-reviewers group, it means that a member of that group will be flagged on any PR's that we raised that contain these files.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

@gep13 gep13 requested a review from AdmiringWorm July 2, 2024 12:14
.github/CODEOWNERS Outdated Show resolved Hide resolved
This is an attempt to ensure that any changes to our dependencies,
whether that is:

* changes to NuGet packages through packages.config files
* updates to custom assemblies which are not tracked through NuGet
packages
* updates to custom executables/assemblies which are added directly to
the Chocolatey CLI Chocolatey Packages

Are trakced and updated properly.  By making these files/folder owned
by the new @chocolatey-credits-reviewers group, it means that a member
of that group will be flagged on any PR's that we raised that contain
these files.
@gep13 gep13 requested a review from AdmiringWorm July 2, 2024 12:23
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, however I would be hesitant to merge this until the following is resolved:

make sure the team @chocolatey/chocolatey-credits-reviewers exists, is publicly visible, and has write access to the repository

@AdmiringWorm AdmiringWorm merged commit 3c18060 into chocolatey:develop Jul 2, 2024
5 checks passed
@AdmiringWorm
Copy link
Member

@gep13 thanks for getting this added.

To verify it is working as expected, it may be best to perhaps open a PR that changes one of the files.

If you open the PR, it should request a review from one of the other members

@gep13 gep13 deleted the codeowners branch July 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants