Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference of unused zip.sh from README.md file #3402

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Remove reference of unused zip.sh from README.md file #3402

merged 1 commit into from
Apr 18, 2024

Conversation

vedantmgoyal9
Copy link
Contributor

Description Of Changes

There is no zip.sh in the repository, hence remove its reference. Also, use wildcards so the docs still apply in case more changes are made in the future.

Motivation and Context

Outdated docs.

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2024

CLA assistant check
All committers have signed the CLA.

@pauby
Copy link
Member

pauby commented Feb 24, 2024

I don't know if this PR is needed, however every PR in this repository requires an associated issue. You'll also need to update your commit message.

@gep13 gep13 changed the title Remove reference of zip.sh from README.md (maint) Remove reference of zip.sh from README.md Apr 18, 2024
@gep13 gep13 changed the title (maint) Remove reference of zip.sh from README.md (doc) Remove reference of zip.sh from README.md Apr 18, 2024
@gep13 gep13 added this to the 2.3.0 milestone Apr 18, 2024
During the process of changing the Chocolatey CLI build to use Cake
rather than UppercuT, the zip.sh file was removed. However, the
documentation in the README didn't remove the reference to the file.

This commit addresses this oversight by removing this line.
@gep13
Copy link
Member

gep13 commented Apr 18, 2024

@vedantmgoyal9 I have taken the liberty of updating your PR, as having looked at the README, it is clear that this was an oversight from when we changed the overall build process for Chocolatey CLI.

Thanks for catching that!

For any future contributions, can you make sure to follow the contributing guidelines so that there isn't any wasted effort on both your part and ours.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit 6b49aab into chocolatey:develop Apr 18, 2024
5 checks passed
@gep13 gep13 changed the title (doc) Remove reference of zip.sh from README.md Remove reference of unusedzip.sh from README.md May 24, 2024
@gep13 gep13 changed the title Remove reference of unusedzip.sh from README.md Remove reference of unused zip.sh from README.md file May 24, 2024
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.3.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants