Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply scripting best practices to output which is shown from some Chocolatey CLI validations #3238

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Apply scripting best practices to output which is shown from some Chocolatey CLI validations #3238

merged 1 commit into from
Jun 30, 2023

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Jun 30, 2023

Description Of Changes

This commit updates the output from the validation results to adhere to
this best practice.

Motivation and Context

When using the full name of an option, the recommendation is always to
use -- and not a single -.

Testing

Not required.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@gep13 gep13 requested a review from AdmiringWorm June 30, 2023 08:43
@gep13
(doc) Apply scripting best practices to output
f973035 
When using the full name of an option, the recommendation is always to
use -- and not a single -.

This commit updates the output from the validation results to adhere to
this best practice.
@gep13 gep13 force-pushed the script-best-practices branch from 2921fe0 to f973035 Compare June 30, 2023 10:36
@gep13 gep13 requested a review from AdmiringWorm June 30, 2023 10:36
AdmiringWorm
AdmiringWorm approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit ddf0df2 into chocolatey:develop Jun 30, 2023
@AdmiringWorm
Copy link
Member

@gep13 Thanks for getting this updated. Great work 👍

@gep13 gep13 deleted the script-best-practices branch June 30, 2023 12:33
@gep13 gep13 added this to the 2.2.0 milestone Jun 30, 2023
@gep13 gep13 changed the title (doc) Apply scripting best practices to output Apply scripting best practices to output which is shown from some Chocolatey CLI validations Jul 25, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdmiringWorm AdmiringWorm AdmiringWorm approved these changes

Assignees
No one assigned
Labels
5 - Released Documentation
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gep13 @AdmiringWorm @choco-bot