(#3181) Let NuGet.Client get the system proxy if none is explicitly set. #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corbob
force-pushed
the
proxies
branch
4 times, most recently
from
ea043da to
987f3f0
Compare
We were checking the registry for proxy settings. Instead of checking here and ignoring other settings, we can (and should) let NuGet.Client poll the System proxy configuration. This commit removes the checking in the registry for these settings as they're no longer necessary.
Previously we passed a new WebProxy to override the NuGet.Client proxy. This commit changes that to pass in a null so that NuGet.Client can know to check the system proxy settings instead.
Mark these tests as FossOnly for now as there is some differences with licensed extension that we need to resolve.
These tests now fail because we're not reading the configuration to get the information, and so it's not in the config object that these tests can see. The system proxy is still tested successfully through it's own Test Kitchen runs that configure the environment for having a proxy.
|
@corbob thank you very much for getting this fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Remove the registry checking that we were doing for proxy settings. Override the NuGet.Client proxy with a null proxy so that it can gather the system proxy information instead.
Motivation and Context
Due to a commit where we were overriding the NuGet.Client proxy to prevent it loading the NuGet configuration file's proxy settings, we were inadvertently ignoring system proxy settings.
Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Requires (#38) Allow getting the system proxy if no proxy was overridden NuGet.Client#39