(#3174) Apply version number normalizing consistently #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdmiringWorm
previously requested changes
Jun 1, 2023
src/chocolatey/infrastructure.app/services/ChocolateyPackageInformationService.cs
Outdated
Show resolved
Hide resolved
src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs
Outdated
Show resolved
Hide resolved
AdmiringWorm
force-pushed
the
normalize-versions-everywhere
branch
2 times, most recently
from
723611a to
e9e4638
Compare
AdmiringWorm
dismissed
their stale review
Changes made by person, needs to be reviewed by someone else.
Went through all references to `ToStringSafe` which were being called on a NuGetVersion instance and changed them all to `ToNormalizedStringChecked`. Additionally, found a place in the upgrade dry-run code that was just missing a call to this method and outputting a non-normalized version string and added it.
gep13
force-pushed
the
normalize-versions-everywhere
branch
from
e9e4638 to
f52fc14
Compare
|
@AdmiringWorm @vexx32 thanks for getting this updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Went through all references to
ToStringSafewhich were being called on a NuGetVersion instance and changed them all toToNormalizedStringChecked.Additionally, found a place in the upgrade dry-run code that was just missing a call to this method and outputting a non-normalized version string and added it.
Motivation and Context
We should be consistent in how we internally and externally represent versions as strings, so that folks relying on our output for consistent comparisons don't need to think too hard about it.
Testing
choco install 7zip --ignore-dependencieschoco upgrade --noop 7zip -r7zip|22.1.0|22.1.0|falseexactly (unless a new version of 7zip has been installed, so just verify the version numbers match exactly)We might be able to add a smoke test package for this case, but I've not had the time to look into it as yet. I will update here if I manage to get that done as well.
Operating Systems Testing
WIn11
Change Types Made
Change Checklist
Related Issue
Fixes #3174