(#23) Handle all keyword for install

[TheCakeIsNaOH]

Description Of Changes

This adds the ability to install all packages from a source via the all
keyword. It runs a list against the current sources, and sets the
package names from that list of packages.

This functionality is only intended to be used with internal
repositories. Therefore a list of public repositories has been added,
and the current sources are checked against it to ensure only internal
sources are specified.

Renames the set_package_names_if_all_is_specified function to
set_local_package_names_if_all_is_specified. This is to increase
clarity with the set_remote_package_names_if_all_is_specified now being added.

Also this throws a not implemented exception if the all keyword is used with
non-nuget alternate sources. This is because the all keyword only has
handling built in for normal sources, and it is better to throw an
error than to have the source try to install a package called "all"

Motivation and Context

Adding the all keyword for install will bring C# choco up to feature parity with PowerShell choco. Or, at least all of the feature parity issues will be closed.

Testing

Run these to validate that choco will throw an error because public repositories are one of the sources:

choco install all --allow-unofficial
choco install all --allow-unofficial --source=https://community.chocolatey.org/api/v2/
choco install all --allow-unofficial --source=https://chocolatey.org/api/v2/
choco install all --allow-unofficial --source=https://www.nuget.org/api/v2/
choco install all --allow-unofficial --source=https://licensedpackages.chocolatey.org/api/v2/
choco install all --allow-unofficial --source=https://push.chocolatey.org/api/v2
choco install all --allow-unofficial --source="'https://community.chocolatey.org/api/v2/;"C:\packages"'"

Run these to validate that alternate sources fail with a notimplemented exception:

choco install all --allow-unofficial --source=WindowsFeatures
choco install all --allow-unofficial --source=ruby
choco install all --allow-unofficial --source=python
choco install all --allow-unofficial --source=webpi
choco install all --allow-unofficial --source=cygwin

Download these packages to a local folder:

• curl 7.81.0
• wget 1.21.2
• iperf2 2.0.13
• iperf2 2.0.14
• iperf2 2.0.14.1001-alpha20201022

Run these commands pointing to that local folder to test the behavior of the all keyword:

Ensure that iperf 2.0.14 (i.e. not the prerelease version), wget and curl are installed:
choco install all --allow-unofficial --source=c:\packages

Ensure that the prerelease iperf is installed when prerelease is specified:
choco install all --allow-unofficial --source=c:\packages --pre

Change Types Made

• Bug fix (non-breaking change)
• Feature / Enhancement (non-breaking change)
• Breaking change (fix or feature that could cause existing functionality to change)

Related Issue

Fixes #23

Change Checklist

• Requires a change to the documentation
• Documentation has been updated
• Tests to cover my changes, have been added
• All new and existing tests passed.
• N/A PowerShell v2 compatibility checked.

[TheCakeIsNaOH]

For reference, here is the previous (PowerShell) implementation of handling the all keyword:
https://github.com/chocolatey-archive/chocolatey/blob/master/src/functions/Chocolatey-InstallAll.ps1

[TheCakeIsNaOH]

TODOs:

• Commits reword
• Fill in PR template
• Local testing, then fill in manually testing section
• Disable or implement "all" keyword for alternate sources
• Check if other specific urls need to be disabled (e.g. other major public nuget repositories, alternate URLs for chocolatey.org/nuget.org?)
• Maybe allow disabling other sources as well via config?
• Documentation in install command help

[coveralls]

Coverage remained the same at 27.567% when pulling 9108aec on TheCakeIsNaOH:install-all into 3892cfb on chocolatey:develop.

[gep13]

Some quick thoughts on this one...

We would want to limit usage of this to only custom sources, i.e. don't allow this on CCR, or Licensed Feed.

And, add a new property to source element, similar to selfService and adminOnly. So we would have installAll as an element.

[TheCakeIsNaOH]

We would want to limit usage of this to only custom sources, i.e. don't allow this on CCR, or Licensed Feed.

This should already be the case, see the PublicNugetSources in ApplicationParameters.cs

And, add a new property to source element, similar to selfService and adminOnly. So we would have installAll as an element.

Would that be a breaking change for the choco source output?

[gep13]

@TheCakeIsNaOH thank you for your work on this. I have taken this for a spin, and made a couple of changes based on a conversation that I have had with @pauby.

We are happy to move forward with this as-is, with some follow up work with regard to the introduction and usage of another property on the source element in the chocolatey.config file to allow setting installAll as enabled/disabled, in the same way that you can with selfService, and adminOnly

[gep13]

LGTM!

[gep13]

@TheCakeIsNaOH thanks again for getting this functionality added in!