Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1866) Avoid recursive search for pending package removal #2218

Merged
merged 1 commit into from
Apr 16, 2021
Merged

(#1866) Avoid recursive search for pending package removal #2218

merged 1 commit into from
Apr 16, 2021

Conversation

jetersen
Copy link
Contributor

@jetersen jetersen commented Mar 25, 2021

fixes #1866
fixes #1941
fixes actions/runner-images#3010

Created a repro over at https://github.com/jetersen/test-choco-pack-github-action

Opened this PR as #1941 was not signed, which I assume was blocking.
This should help alleviate the initial choco startup on CI systems.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2021

CLA assistant check
All committers have signed the CLA.

@gep13
Copy link
Member

gep13 commented Apr 16, 2021

@jetersen as you have pointed out, the CLA hasn't been signed on the other PR, so yes, I feel we can move forward with this PR, but I will update the commit message here to provide some additional context.

Previously, Chocolatey would search all sub directories when trying to
remove pending packages as part of other commands. This was causing
several second execution times when sub directories were large and/or
symlinked on a network drive.

By restricting the cleanup to the top directory only, the command
execution times will be much more consistent.

Co-authored-by: Tim Guenthner <[email protected]>
@gep13 gep13 changed the base branch from master to stable April 16, 2021 13:35
@gep13 gep13 changed the title Avoid recursive search for pending package removal (#1866) Avoid recursive search for pending package removal Apr 16, 2021
@jetersen
Copy link
Contributor Author

@gep13 much appreciated

@gep13 gep13 merged commit 4b17e01 into chocolatey:stable Apr 16, 2021
@gep13
Copy link
Member

gep13 commented Apr 16, 2021

@jetersen thanks again for taking the time to raise this PR!

@jetersen jetersen deleted the fix/recursivePending branch April 16, 2021 21:49
@jetersen
Copy link
Contributor Author

@gep13 the last chocolatey release was quite a while ago. What are the chances for seeing a release of this in the near future?

@TheCakeIsNaOH
Copy link
Member

@jetersen here are the items that are intended to be completed for 0.10.16, which is the next release:
https://github.com/chocolatey/choco/milestone/43

@jetersen
Copy link
Contributor Author

jetersen commented Apr 16, 2021

So, that's a hard no? Seems more frequent releases would be better?

@TheCakeIsNaOH
Copy link
Member

So, that's a hard no?

I'm just a contributor, so I am not the one making the decisions.
If there is say a security vulnerability discovered or something, then a release might be made sooner.
But fixing those issues are the current plan.

@jetersen
Copy link
Contributor Author

@gep13 I can see v0.10.16 is TBD #2266
This PR fixes an annoying issue do we have a ETA for the release? 😅

@pauby
Copy link
Member

pauby commented Jun 21, 2021

We don't have an ETA on the 0.10.16 release at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants