-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1866) Avoid recursive search for pending package removal #2218
Conversation
@jetersen as you have pointed out, the CLA hasn't been signed on the other PR, so yes, I feel we can move forward with this PR, but I will update the commit message here to provide some additional context. |
Previously, Chocolatey would search all sub directories when trying to remove pending packages as part of other commands. This was causing several second execution times when sub directories were large and/or symlinked on a network drive. By restricting the cleanup to the top directory only, the command execution times will be much more consistent. Co-authored-by: Tim Guenthner <[email protected]>
@gep13 much appreciated |
@jetersen thanks again for taking the time to raise this PR! |
@gep13 the last chocolatey release was quite a while ago. What are the chances for seeing a release of this in the near future? |
@jetersen here are the items that are intended to be completed for 0.10.16, which is the next release: |
So, that's a hard no? Seems more frequent releases would be better? |
I'm just a contributor, so I am not the one making the decisions. |
We don't have an ETA on the 0.10.16 release at the moment. |
fixes #1866
fixes #1941
fixes actions/runner-images#3010
Created a repro over at https://github.com/jetersen/test-choco-pack-github-action
Opened this PR as #1941 was not signed, which I assume was blocking.
This should help alleviate the initial choco startup on CI systems.