(#886) added support for force and timeout in packages.config file #2187
Conversation
|
|
src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs
Outdated
Show resolved
Hide resolved
|
Hi @boussaffawalid! Thanks so much for taking the time to improve Chocolatey. It looks like a really good start! Note that @AdmiringWorm dropped a note in on some work to be done with the code, I'll note that the commit message/body needs to talk about the why of the change. If you haven't read over CONTRIBUTING, please take a look at that to allow this to be easier for us to incorporate the change without a lot of back and forth - especially this section: https://github.com/chocolatey/choco/blob/master/CONTRIBUTING.md#prepare-commits. Once you've fixed up those sections, also take a look at the rest of the document as it details how to push back the changes on the same branch/commit. Let us know if you have any questions. 👍 |
boussaffawalid
force-pushed
the
support-more-switches-packages.config
branch
2 times, most recently
from
3b36038 to
5083bed
Compare
gep13
changed the title
gep13
force-pushed
the
support-more-switches-packages.config
branch
from
5083bed to
2a08972
Compare
gep13
force-pushed
the
support-more-switches-packages.config
branch
from
2a08972 to
09e5826
Compare
This commit adds the force and the commandExecutionTimeoutSeconds attributes to the package element within the packages.config file. These additional properties will mean that a user will be able to control these options via the packages.config file when running choco install packages.config. Follow up commits will add other attributes to the package element so that all aspects of the installation can be controlled via the packages.config file.
gep13
force-pushed
the
support-more-switches-packages.config
branch
from
09e5826 to
867403b
Compare
|
The failing build here is due to a known issue with the build running on Ubuntu, so for now, I am going to move forward with the merge. |
|
@boussaffawalid thank you for taking the time to raise this PR, and congratulations on your first time contribution to Chocolatey! We really appreciate your help here! |
Added support to timeout and force in packages.config
This is now supported
Relates to #886.
Other PR's will be required to bring in the other options that can then be controlled via the packages.config file.