(GH-1859) Fix error message for missing 32-bit URL #1867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 64-bit-only packages, when running Get-ChocolateyWebFile.ps1 on a 64-bit system having `$Env:ChocolateyForceX86 = $true`, the error message would read: "This package does not support 64 bit architecture." Instead, we should inform that the package does not support 32-bit systems.
|
Probably https://github.com/chocolatey/choco/wiki/Troubleshooting#error-this-package-does-not-support-64-bit-architecture has to be adapted too. |
ferventcoder
reviewed
Jul 2, 2019
| @@ -262,7 +262,7 @@ param( | |||
| # If we're on 32 bit or attempting to force 32 bit and there is no | |||
| # 32 bit url, we need to throw an error. | |||
| if ($url -eq $null -or $url -eq '') { | |||
| throw "This package does not support $bitWidth bit architecture." | |||
| throw "This package does not support $bitPackage architecture." | |||
|
Rebased and merged into stable at 34151e5. Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 64-bit-only packages, when running Get-ChocolateyWebFile.ps1 on a
64-bit system having
$Env:ChocolateyForceX86 = $true, the errormessage would read: "This package does not support 64 bit architecture."
Instead, the message should inform that the package does not support
32-bit systems.
Closes #1859