(GH-1141) Fix constant proxy NREs for some environments #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments, (new-object System.Net.WebClient).Proxy -eq $null is true, as is [System.Net.WebRequest]::DefaultWebProxy -eq $null. This means the IsBypassed() method was being called on a null object. This checks the object's existence before using that method.
Fix a copy-paste issue since one of the three files being updated uses a different variable name.
|
Awesome. Can you do me a favor and look at the CLA? This does not quite fall into what we would consider a trivial contribution. Much appreciated. Thanks! |
ferventcoder
requested changes
Jan 24, 2017
|
OK, I got it signed. |
ferventcoder
approved these changes
Feb 17, 2017
|
Merged into stable at cf26b8b |
|
@brianary Thanks for your contribution! This will be released in 0.10.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments, (new-object System.Net.WebClient).Proxy -eq $null
is true, as is [System.Net.WebRequest]::DefaultWebProxy -eq $null. This
means the IsBypassed() method was being called on a null object. This
checks the object's existence before using that method.
Fixes #1141