Show human-readable file sizes when downloading #363
Comments
|
No worries. Please read over our CONTRIBUTING document before moving forward - knowing ahead of time whether you can sign the CLA or not is the biggest hurdle for some folks. |
ferventcoder
added a commit
that referenced
this issue
Sep 15, 2015
(GH-363) Show human-readable file sizes when downloading
ferventcoder
added a commit
that referenced
this issue
Oct 11, 2015
* master: (61 commits) (version) 0.9.10-beta1 (doc) update release notes/nuspec for 0.9.10 (GH-431) Changed Count to ListCount. Added xml docs to List and ListCount. (GH-431) Add Count to IListCommand Uses the IQueryable changes to add an efficient count for retrieving the number of results that would be returned by a list, usually in a much faster, more efficient way. (GH-431) Update Nuget List to use IQueryable as far down as makes sense. Updated Nuget List to attempt to use IQueryable all the way down for queries executed against service based repositories. This allows chocolatey to defer filtering, sorting, and paging to the server rather than the client. Reverts back to the old logic, though, for everything else. (GH-433) Externalize some more package information. Externalizes more package information that was available through the API as properties, but were marked internal. Allows full access to all Package information. (GH-427) Add paging to ListCommand (GH-71) Add priority property to ChocolateySource (GH-416) Named arguments issue after merge (GH-363) Show human-readable file sizes when downloading (GH-392) pass 4.0 reference assemblies to ilmerge (GH-390) Fix log4net dependency version in nuspec (maint) registry specs are Windows only (maint) define windows only tests (doc) update changelog (version) 0.9.10-alpha series (GH-14) Throw when windowsfeature is not plural (GH-14) Log source type evaluated (maint) removing unused variable (GH-14) Allow alternative sources to interact ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Google Groups: https://groups.google.com/forum/#!topic/chocolatey/KIEHvPtVEqs
When downloading any file, Chocolatey shows the size in bytes "Saving 8911368 of 9252864". This is difficult for humans to read and something like "Saving 8.50 MB of 8.82 MB" or "Saving 8.50 MB of 8.82 MB (8911368/9252864)" would be preferred.
Can I submit a PR for this?
If I'm not wrong, this would require including a Format-FileSize helper function and changes in these files:
https://github.com/chocolatey/choco/blob/master/src/chocolatey.resources/helpers/functions/Get-WebFile.ps1
https://github.com/chocolatey/choco/blob/master/src/chocolatey.resources/helpers/functions/Get-FtpFile.ps1
https://github.com/chocolatey/choco/blob/master/src/chocolatey.resources/chocolatey.resources.csproj
I just downloaded Chocolatey few hours ago so please let me know if I'm missing anything.
The text was updated successfully, but these errors were encountered: