Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove historical folder migration logic from chocolateysetup.psm1 #3501

Closed
2 tasks done
gep13 opened this issue Aug 15, 2024 · 2 comments · Fixed by #3528
Closed
2 tasks done

Remove historical folder migration logic from chocolateysetup.psm1 #3501

gep13 opened this issue Aug 15, 2024 · 2 comments · Fixed by #3528
Assignees
@vexx32
Labels
5 - Released Improvement
Milestone
2.4.0

Comments

@gep13
Copy link
Member

gep13 commented Aug 15, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

No. There is no specific problem associated with this task, it is more around tidying up of code that is no longer required.

Describe The Solution. Why is it needed?

Within the chocolateysetup.psm1 file, there are a number of functions that were specifically created to aid with the migration from the old Chocolatey CLI installation folder C:\Chocolatey to the new one C:\ProgramData\Chocolatey.

This code is no longer required, and can be removed.

Additional Context

The migration code was added to the chocolateysetup.psm1 file in version 0.9.9, which was shipped in March 2015. Chocolatey CLI is now on its second major version, and the upgrade steps to get to 2.x first involve getting to 1.4.0. As a result, this migration code is no longer required.

Related Issues

N/A
@gep13 gep13 added this to the 2.4.0 milestone Aug 15, 2024
@gep13
Copy link
Member Author

gep13 commented Aug 15, 2024

@vexx32 I have assigned you to this issue, but check with @pauby about priorities before picking this up.

vexx32 added a commit to vexx32/choco that referenced this issue Oct 7, 2024
@vexx32
(chocolatey#3501) Remove old install migration code
c49ddac 
This migration path hasnt been supported or used since pre-1.0 versions
of Chocolatey and is dead code.

Removing this now to simplify the install process somewhat and get the
old code out of the way as it's not used at all.
@vexx32 vexx32 mentioned this issue Oct 7, 2024
Merged
10 tasks
vexx32 added a commit to vexx32/choco that referenced this issue Oct 8, 2024
@vexx32
(chocolatey#3501) Remove old install migration code
2bdb4e9 
This migration path hasnt been supported or used since pre-1.0 versions
of Chocolatey and is dead code.

Removing this now to simplify the install process somewhat and get the
old code out of the way as it's not used at all.
vexx32 added a commit to vexx32/choco that referenced this issue Oct 16, 2024
@vexx32
(chocolatey#3501) Remove old install migration code
a36cab5 
This migration path hasnt been supported or used since pre-1.0 versions
of Chocolatey and is dead code.

Removing this now to simplify the install process somewhat and get the
old code out of the way as it's not used at all.
@vexx32 vexx32 mentioned this issue Oct 16, 2024
Open
2 tasks
vexx32 added a commit to vexx32/choco that referenced this issue Oct 29, 2024
@vexx32
(chocolatey#3501) Remove old install migration code
44a9fd1 
This migration path hasnt been supported or used since pre-1.0 versions
of Chocolatey and is dead code.

Removing this now to simplify the install process somewhat and get the
old code out of the way as it's not used at all.
corbob added a commit that referenced this issue Oct 29, 2024
@corbob
Merge pull request #3528 from vexx32/3051-remove-old-migration-logic
808c28b 
(#3501) Remove old install migration code
@corbob corbob added 4 - Done and removed 3 - Review labels Nov 4, 2024
@vexx32 vexx32 changed the title Chocolatey folder migration logic should be removed from chocolateysetup.psm1 file Remove Chocolatey folder migration logic from chocolateysetup.psm1 Nov 12, 2024
@vexx32 vexx32 changed the title Remove Chocolatey folder migration logic from chocolateysetup.psm1 Remove historical folder migration logic from chocolateysetup.psm1 Nov 12, 2024
@vexx32
Copy link
Member

vexx32 commented Nov 12, 2024

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

@vexx32 vexx32 removed the 4 - Done label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vexx32 vexx32

Labels
5 - Released Improvement
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

(#3501) Remove old install migration code vexx32/choco
3 participants
@gep13 @corbob @vexx32