Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework build process to remove the use of -unpackself command #3427

Closed
2 tasks done
vexx32 opened this issue Apr 19, 2024 · 1 comment · Fixed by #3536
Closed
2 tasks done

Rework build process to remove the use of -unpackself command #3427

vexx32 opened this issue Apr 19, 2024 · 1 comment · Fixed by #3536
Assignees
@vexx32
Labels
5 - Released Improvement
Milestone
2.4.0

Comments

@vexx32
Copy link
Member

vexx32 commented Apr 19, 2024

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

Per #3426, we are looking to deprecate -unpackself. We will need to replace it in our build processes.

Describe The Solution. Why is it needed?

Replace usage of -unpackself to generate the directory structure from the chocolatey.resources assembly with some straightforward file copies from the project into the nuget/chocolatey/choco directory.

Additional Context

No response

Related Issues
@vexx32 vexx32 mentioned this issue Apr 19, 2024
Open
2 tasks
@gep13 gep13 added this to the 2.4.0 milestone Jun 6, 2024
@vexx32 vexx32 self-assigned this Oct 24, 2024
vexx32 added a commit to vexx32/choco that referenced this issue Oct 25, 2024
@vexx32
(chocolatey#3427) Remove use of -unpackself from the build
2131ae1 
This command is deprecated, so we need to remove it from our build
to give ourselves the ability to actually remove that functionality in
future.
vexx32 added a commit to vexx32/choco that referenced this issue Oct 25, 2024
@vexx32
(chocolatey#3427) Remove use of -unpackself from the build
5f5b019 
This command is deprecated, so we need to remove it from our build
to give ourselves the ability to actually remove that functionality in
future.
vexx32 added a commit to vexx32/choco that referenced this issue Oct 25, 2024
@vexx32
(chocolatey#3427) Remove use of -unpackself from the build
ceeb42c 
This command is deprecated, so we need to remove it from our build
to give ourselves the ability to actually remove that functionality in
future.
@vexx32 vexx32 mentioned this issue Oct 25, 2024
Merged
10 tasks
vexx32 added a commit to vexx32/choco that referenced this issue Oct 28, 2024
@vexx32
(chocolatey#3427) Remove use of -unpackself from the build
e5ce2a4 
This command is deprecated, so we need to remove it from our build
to give ourselves the ability to actually remove that functionality in
future.
vexx32 added a commit to vexx32/choco that referenced this issue Oct 28, 2024
@vexx32
(chocolatey#3427) Remove use of -unpackself from the build
213596f 
This command is deprecated, so we need to remove it from our build
to give ourselves the ability to actually remove that functionality in
future.

To facilitate this, the embedded resource files are being copied to the
build output folder so that the Cake build can easily copy them to the
locations they are needed.

In the longer-term these resource files will be relegate to `<None>`
rather than `<EmbeddedResource>` when we fully remove the `-unpackself`
command from Chocolatey CLI, and we will not need to be shipping
them embedded in the executable itself any longer.
corbob pushed a commit to vexx32/choco that referenced this issue Nov 4, 2024
@vexx32 @corbob
(chocolatey#3427) Remove use of -unpackself from the build
ca4f5ef 
This command is deprecated, so we need to remove it from our build
to give ourselves the ability to actually remove that functionality in
future.

To facilitate this, the embedded resource files are being copied to the
build output folder so that the Cake build can easily copy them to the
locations they are needed.

In the longer-term these resource files will be relegate to `<None>`
rather than `<EmbeddedResource>` when we fully remove the `-unpackself`
command from Chocolatey CLI, and we will not need to be shipping
them embedded in the executable itself any longer.
corbob added a commit that referenced this issue Nov 4, 2024
@corbob
Merge pull request #3536 from vexx32/3427-build-remove-unpackself
f65afd1 
(#3427) Rework build to remove use of -unpackself
@corbob corbob added 4 - Done and removed 3 - Review labels Nov 4, 2024
@vexx32 vexx32 changed the title Rework build process to remove the use of -unpackself Rework build process to remove the use of -unpackself command Nov 12, 2024
@vexx32
Copy link
Member Author

vexx32 commented Nov 12, 2024

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

@vexx32 vexx32 removed the 4 - Done label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vexx32 vexx32

Labels
5 - Released Improvement
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

(#3427) Rework build to remove use of -unpackself vexx32/choco
3 participants
@gep13 @corbob @vexx32