-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation of Chocolatey should add a more descriptive comment when adding Chocolatey tab-completion module to profile #2443
Labels
5 - Released
Improvement
IN REGRESSION TEST SUITE
These are things that are handled by tools like Test-Kitchen
Milestone
Comments
corbob
added
the
ADD AUTO TESTS
Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added
label
Mar 1, 2022
9 tasks
AdmiringWorm
added a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 3, 2022
This commit updates the injection of importing the chocolatey profile to include extra comment details to mention what the import of the module is used for.
AdmiringWorm
added a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 3, 2022
This commit updates the injection of importing the chocolatey profile to include extra comment details to mention what the import of the module is used for.
gep13
pushed a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 7, 2022
This commit updates the injection of importing the chocolatey profile to include extra comment details to mention what the import of the module is used for.
gep13
pushed a commit
to AdmiringWorm/choco
that referenced
this issue
Mar 7, 2022
This commit updates the injection of importing the chocolatey profile to include extra comment details to mention what the import of the module is used for.
gep13
added a commit
that referenced
this issue
Mar 7, 2022
…a-more-descriptive-comment-when-adding-Chocolatey-tab-completion-module-to-profile (#2443) Update comment about chocolatey profile
corbob
added
IN REGRESSION TEST SUITE
These are things that are handled by tools like Test-Kitchen
and removed
ADD AUTO TESTS
Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added
labels
Mar 9, 2022
10 tasks
vexx32
added a commit
to vexx32/choco
that referenced
this issue
Mar 14, 2022
10 tasks
gep13
pushed a commit
to vexx32/choco
that referenced
this issue
Mar 15, 2022
gep13
added a commit
that referenced
this issue
Mar 15, 2022
(#2443) Fix misspellings for profile text
gep13
changed the title
Installer should add a more descriptive comment when adding Chocolatey tab-completion module to profile
Installation of Chocolatey should add a more descriptive comment when adding Chocolatey tab-completion module to profile
Mar 18, 2022
gep13
added a commit
that referenced
this issue
Mar 18, 2022
* release/1.0.0: (65 commits) (version) v1.0.0 (#2443) Fix misspellings for profile text (#2468) Remove choco update command (#2468) Remove choco version command (#2602) Add 1.0.0 of shimgen and update shims (#89) Remove cpack shims on package upgrades (#89) Remove cpack shim for choco pack (maint) Update deprecation notice for config settings (build) Additional tweaks to version numbers (build) Add SolutionVersion.cs file to artifacts (docs) Update committers docs with correct/fixed links (build) Minor tweaks to build files (#2615) Reference CREDITS file for other licenses (build) Refactor Nuget Upload (build) Added missing Kotlin import (maint) Whitespace (#2614) Update 7zip / Shimgen licenses (#2614) Update project contributors (#2641) Minor tweaks to wording and formatting (#2462) Remove mention of alias for search comand ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Released
Improvement
IN REGRESSION TEST SUITE
These are things that are handled by tools like Test-Kitchen
What You Are Seeing?
When installing Chocolatey, the choco installer code below automatically inserts the quoted code to a profile, including a comment that is essentially redundant and somewhat misleading:
choco/nuget/chocolatey/tools/chocolateysetup.psm1
Lines 613 to 620 in f6d6140
What is Expected?
Comment should mention that the module load enables Chocolatey tab completion, so users know what it's actually doing and don't remove it without knowing what they're disabling.
Quote from a user:
I would suggest the comment should read something along the lines of:
We should create a shortlink to the doc to be used here instead of the long link, but you get the idea. 🙂
How Did You Get This To Happen? (Steps to Reproduce)
Run the Chocolatey install script.
Output Log
N/A
The text was updated successfully, but these errors were encountered: