Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

license - If license is found in top-level folder or named wrong, choco should warn #1503

Closed
ferventcoder opened this issue Feb 20, 2018 · 3 comments
Closed

license - If license is found in top-level folder or named wrong, choco should warn #1503

ferventcoder opened this issue Feb 20, 2018 · 3 comments
Assignees
@ferventcoder
Labels
5 - Released Improvement Pro/Business
Milestone
0.10.12

Comments

@ferventcoder
Copy link
Member

ferventcoder commented Feb 20, 2018 •
edited
Loading

We tend to see a lot of folks putting the license in the $env:ChocolateyInstall directory and not a license subdirectory, even though most of our instructions say to create the license folder. To be fair, there are a few steps there, so it's understandable someone might miss that.

What we should do is at the very least warn folks, and maybe if the user has access, we should create the license subdirectory and move the file. Then load it up.
@ferventcoder ferventcoder added this to the 0.10.10 milestone Feb 20, 2018
@ferventcoder
Copy link
Member Author

Maybe check for British spelling as well

@ferventcoder ferventcoder modified the milestones: 0.10.10, 0.10.11 Apr 9, 2018
@ferventcoder ferventcoder changed the title License - If license is found in top-level folder, choco should warn (or just allow it) License: If license is found in top-level folder, choco should warn (or just allow it) May 2, 2018
@ferventcoder ferventcoder modified the milestones: 0.10.11, 0.10.12 May 3, 2018
@ferventcoder ferventcoder changed the title License: If license is found in top-level folder, choco should warn (or just allow it) License: If license is found in top-level folder or named wrong, choco should warn Dec 16, 2018
@ferventcoder
Copy link
Member Author

Now that we'll be sending licenses as txt files attached to an email to cut down on getting filtered by malware or spam detection software, let's make sure we warn users when they forget to rename the license to chocolatey.license.xml. Let's also catch if they just name it completely wrong as well.

@ferventcoder ferventcoder self-assigned this Dec 16, 2018
@ferventcoder
Copy link
Member Author

This will be released with 0.10.12

ferventcoder added a commit that referenced this issue Dec 16, 2018
@ferventcoder
(GH-1503) Warn on incorrectly named license file
a87aeb7 
If choco does not find a valid license, but it finds other files in the
license folder, assume that a user misnamed the file or did not rename
it properly. Log an error and warning with information on how to
correct the issue.

If a user puts the license in the top level folder, and also if they
forget to rename the file, log an error and warning with information on
how to correct the issue.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Dec 16, 2018
@ferventcoder
Merge branch 'stable'
8daccd4 
* stable:
  (chocolateyGH-1131) logging: better defaults for ERROR
  (chocolateyGH-1131) logging: better defaults for WARN
  (chocolateyGH-1131) logging: better defaults for INFO
  (chocolateyGH-1665) sign init.ps1 file
  (doc) More info on license next steps
  (chocolateyGH-1503) Warn on incorrectly named license file
  (chocolateyGH-1292) add note on manifest caching
@ferventcoder ferventcoder changed the title License: If license is found in top-level folder or named wrong, choco should warn license - If license is found in top-level folder or named wrong, choco should warn Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Improvement Pro/Business
Projects
None yet
Milestone
0.10.12
Development

No branches or pull requests
2 participants
@ferventcoder @gep13