Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty directories within Chocolatey template folder #1003

Closed
caleyg opened this issue Oct 6, 2016 · 0 comments · Fixed by #2402
Closed

Support empty directories within Chocolatey template folder #1003

caleyg opened this issue Oct 6, 2016 · 0 comments · Fixed by #2402
Assignees
@TheCakeIsNaOH
Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Priority_LOW
Milestone
0.12.0

Comments

@caleyg
Copy link

caleyg commented Oct 6, 2016

currently it seems that when there is a template under $env:ChocolateyInstall\templates\ and that template has a empty directory in it, say code. If one was to call that template when making a new package (choco new pkg_name -t pkg_template). When chocolatey creates the new package, the empty directory is never created.
@ferventcoder ferventcoder added this to the 0.10.4 milestone Oct 6, 2016
@ferventcoder ferventcoder modified the milestones: 0.10.4, 0.10.5 Jan 21, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.5, 0.10.6, 0.10.7 Mar 30, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.7, 0.10.8 Jun 6, 2017
@ferventcoder ferventcoder modified the milestones: 0.10.9, 0.10.10 Aug 27, 2017
@gep13 gep13 modified the milestones: 0.10.16, 0.10.17 May 31, 2019
@ferventcoder ferventcoder modified the milestones: 0.10.17, 0.10.18 Jan 14, 2020
@ferventcoder ferventcoder modified the milestones: 0.10.18, 0.10.x Apr 14, 2021
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Oct 13, 2021
@TheCakeIsNaOH
(chocolatey#1003) Include empty directories from templates
f9686bb 
Create the full directory structure of the a custom template before
the files are written. This is so empty directories in the template are
replicated in the new package.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Oct 13, 2021
@TheCakeIsNaOH
(chocolatey#1003) Include empty directories from templates
90b7b9d 
Create the full directory structure of a custom template before the
files are written. This is so empty directories in the template are
replicated in the new package.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Oct 13, 2021
Merged
7 tasks
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Oct 23, 2021
@TheCakeIsNaOH
(chocolatey#1003) Include empty directories from templates
2fa3f02 
Create the full directory structure of a custom template before the
files are written. This is so empty directories in the template are
replicated in the new package.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Oct 23, 2021
@TheCakeIsNaOH
(chocolatey#1003) Add tests to make sure empty folder are created
66943b9 
Validates that empty directories from a custom template are recreated
in the generated package source.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 13, 2021
@TheCakeIsNaOH
(chocolatey#1003) Include empty directories from templates
8e80dc4 
Create the full directory structure of a custom template before the
files are written. This is so empty directories in the template are
replicated in the new package.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Nov 13, 2021
@TheCakeIsNaOH
(chocolatey#1003) Add tests to make sure empty folder are created
e37fb88 
Validates that empty directories from a custom template are recreated
in the generated package source.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Dec 23, 2021
@TheCakeIsNaOH @gep13
(chocolatey#1003) Include empty directories from templates
027a720 
Create the full directory structure of a custom template before the
files are written. This is so empty directories in the template are
replicated in the new package.
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Dec 23, 2021
@TheCakeIsNaOH @gep13
(chocolatey#1003) Add tests to make sure empty folder are created
fa054cd 
Validates that empty directories from a custom template are recreated
in the generated package source.
@gep13 gep13 modified the milestones: 0.11.x, 0.12.0 Dec 23, 2021
gep13 added a commit that referenced this issue Dec 23, 2021
@gep13
Merge pull request #2402 from TheCakeIsNaOH/template-dirs
b04722c 
(#1003) Include empty directories from templates
@gep13 gep13 added 4 - Done and removed 3 - Review labels Dec 23, 2021
@corbob corbob added the ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added label Jan 5, 2022
@gep13 gep13 changed the title If there is an empty directory in a templates directory, please include it in the new packages when the template is called Support empty directories within Chocolatey template folder Jan 17, 2022
@corbob corbob added IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen and removed ADD AUTO TESTS Things that typically go to Test-Kitchen - once completed, IN REGRESSION TEST SUITE label added labels Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheCakeIsNaOH TheCakeIsNaOH

Labels
5 - Released Improvement IN REGRESSION TEST SUITE These are things that are handled by tools like Test-Kitchen Priority_LOW
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

(#1003) Include empty directories from templates TheCakeIsNaOH/choco
5 participants
@ferventcoder @gep13 @caleyg @corbob @TheCakeIsNaOH