Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-20) Add cChocoConfig resource #145

Merged
merged 2 commits into from
Oct 20, 2020
Merged

(GH-20) Add cChocoConfig resource #145

merged 2 commits into from
Oct 20, 2020

Conversation

mkevenaar
Copy link
Contributor

This resource allows users to change Chocolatey Config
settings using an DSC resource.

Fixes #20

replaces PR #132

pauby
pauby requested changes May 10, 2020
View reviewed changes
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes to be made.

Can I ask for a few more comments in the code as well?

DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
DSCResources/cChocoConfig/cChocoConfig.psm1 Outdated Show resolved Hide resolved
@pauby pauby mentioned this pull request May 10, 2020
Closed
@mkevenaar mkevenaar requested a review from pauby May 10, 2020 18:42
@mkevenaar
Copy link
Contributor Author

@pauby I have updated the code with your feedback.

pauby
pauby reviewed May 21, 2020
View reviewed changes
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This awesome. Love the comments. Just one more question left.

@mkevenaar
(chocolateyGH-20) add cChocoConfig resource
f8bb5f1 
This resource allows users to change Chocolatey Config
settings using an DSC resource.
@mkevenaar mkevenaar requested a review from pauby June 2, 2020 07:21
This was referenced Jun 23, 2020
Closed
Open
@pauby pauby merged commit feffeed into chocolatey:development Oct 20, 2020
@pauby
Copy link
Member

pauby commented Oct 20, 2020

Awesome work! Thanks for your contribution!

@pauby pauby changed the title (GH-20) add cChocoConfig resource (GH-20) Add cChocoConfig resource Oct 20, 2020
@mkevenaar mkevenaar deleted the feature/GH-20 branch October 20, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauby pauby pauby requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cChocoConfig Resource
2 participants
@mkevenaar @pauby