Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes from Chocolatey 1.0.0 #496

Closed
OraDotNetDev opened this issue Mar 23, 2022 · 6 comments
Closed

Breaking changes from Chocolatey 1.0.0 #496

OraDotNetDev opened this issue Mar 23, 2022 · 6 comments
Assignees

Comments

@OraDotNetDev
Copy link

OraDotNetDev commented Mar 23, 2022

There are a few references to helper functions which have been removed in Chocolatey 1.0.0 chocolatey/choco#2469.

Do these now need to be removed (and replaced)?

Write-ChocolateySuccess 'MyPackage'

Write-ChocolateyFailure 'MyPackage' $($_.Exception.Message)

Write-ChocolateySuccess '$name'

Write-ChocolateyFailure '$name' `$(`$_.Exception.Message)

@pauby
Copy link
Member

pauby commented Mar 23, 2022

For backwards compatibility the Chocolatey Community will be adding those functions into an extension module (likely chocolatey-core.extension) in the short term. Longer term we will need to remove this functions from the Boxstarter code.

Thanks for picking that up @OraDotNetDev

@pauby pauby added Bug Issues where something has happened which was not expected or intended 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint labels Mar 23, 2022
@gep13
Copy link
Member

gep13 commented Mar 23, 2022

While updating this, it might be advisable to remove any usage of the now deprecated Chocolatey shims, or example cinst, clist, etc.

@pauby pauby added the Priority_HIGH Issues that are considered to be a high priority to get fixed label Mar 23, 2022
@OraDotNetDev
Copy link
Author

OraDotNetDev commented Mar 23, 2022

While updating this, it might be advisable to remove any usage of the now deprecated Chocolatey shims, or example cinst, clist, etc.

Not very familiar with Boxstarter, but it looks as though it has it's own cup, cinst, choco wrapper functions to override the deprecated Chocolatey shims.

Should calls to these Boxstarter functions now also be removed and replaced with calls to the native choco commands?

@mwallner
Copy link
Member

Hi @OraDotNetDev - thanks for bringing this up, we'll definitely need to do something about the Write-Chocolatey... functions being deprecated. (I'll take care of it asap, but won't be in the upcoming 'v3' release)

As for cinst / cup / ... there's really nothing to be done there - these shims are monkey patched by the wrapper functions you discovered.

@mwallner mwallner self-assigned this Apr 12, 2022
@mwallner mwallner added this to the 3.0.1 milestone Apr 12, 2022
@pauby
Copy link
Member

pauby commented Apr 18, 2022

A chocolatey compatibility extension has been created that might help with this.

mwallner added a commit to mwallner/boxstarter that referenced this issue Apr 24, 2022
@mwallner
Copy link
Member

I'm going to close this issue as it is going to be implicitly fixed with Boxstarter v3 / GH-479

@gep13 gep13 removed this from the 3.0.1 milestone Apr 25, 2022
@gep13 gep13 removed Bug Issues where something has happened which was not expected or intended 0 - Backlog Issue is accepted, but is not ready to be worked on or not in current sprint Priority_HIGH Issues that are considered to be a high priority to get fixed labels Apr 25, 2022
gep13 pushed a commit to mwallner/boxstarter that referenced this issue Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants