(GH-629) Separate app.manifest #630
Conversation
|
This is in WIP because it appears there is some work to do to see that the ChocolateyGUI.exe.manifest gets included in the MSI |
By default highestAvailable is desired for UAC prompting behavior, but sometimes there are groups that provide some level of elevation (Network Configuration Operators Group) that also mean that UAC will prompt. This is undesirable behavior in shops that might want to use self-service and have Chocolatey GUI run as the user that invoked without any elevation being requested. To allow this behavior, app.manifest can not be embedded, but must sit next to ChocolateyGUI.exe so that it can be changed for those situations that require it by those users.
ferventcoder
force-pushed
the
ticket/629_separate_app_manifest
branch
from
8d62716 to
dc7bc74
Compare
|
I took a cursory look but I don't know where I might need to change to be sure that ChocolateyGUI.exe.manifest gets included. The XSLT filters "ChocolateyGUI.exe" files out and then somewhere else the config and exe are put back in as named components. I think that the manifest needs the same treatment but I have not tracked down where that is just yet. @gep13 ? |
|
@ferventcoder I have just pushed a new commit onto your branch. With this change in place, the MSI that is generated now includes the new manifest file, and on installation, it can be found here:
Next to the ChocolateyGUI.exe |
ferventcoder
changed the title
ferventcoder
changed the title
ferventcoder
changed the title
This comment has been minimized.
This comment has been minimized.
| @@ -92,6 +92,9 @@ | |||
| <Component Id="ChocolateyGui.exe.config" Guid="6C3AE56F-1AA3-4145-BFA9-345BBCC5C3D1"> | |||
| <File Id="ChocolateyGui.exe.config" Source="$(var.GuiTargetDir)/ChocolateyGui.exe.config" KeyPath="yes" Checksum="yes" /> | |||
| </Component> | |||
| <Component Id="ChocolateyGui.exe.manifest" Guid="AEA5D8AE-4274-444E-AEB5-988492C6919E"> | |||
| <File Id="ChocolateyGui.exe.manifest" Source="$(var.GuiTargetDir)/ChocolateyGui.exe.manifest" KeyPath="yes" Checksum="yes" /> | |||
| </Component> | |||
There was a problem hiding this comment.
I figured it was something like that. Thanks for catching that!
This comment has been minimized.
This comment has been minimized.
|
We should add these notes in as well for folks changing this so they don't scratch their heads - chocolatey/choco#1292 (comment) |
Windows behavior of manifest caching is enough to make even the best of admins and developers want to tear out their hair until they realize there is a cache and changes to the manifest are completely ignored by Windows. So leave a breadcrumb here so that folks know if they make a change to the manifest file, they will need to "touch" the file they are trying to get the manifest to take effect for - in this case ChocolateyGUI.exe. The modification date will need changed to clue Windows in that there is a new manifest. This is only when changing the file AFTER the exe / modification date has been run even once. It's better to just say to always update the modification date as someone may not know whether the file has been ran before.
|
I added some notes to keep folks from being perplexed IF they do change this file. This is ready for review. |
|
@ferventcoder your changes have been merged, thanks for your contribution 👍 |
By default highestAvailable is desired for UAC prompting behavior, but sometimes there are groups that provide some level of elevation (Network Configuration Operators Group) that also mean that UAC will
prompt. This is undesirable behavior in shops that might want to use self-service and have Chocolatey GUI run as the user that invoked without any elevation being requested. To allow this behavior, app.manifest can not be embedded, but must sit next to ChocolateyGUI.exe so that it can be changed for those situations that require it by those users.
Closes #629