Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Add space between words in labels #55

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This updates the common labels that is synchronized to different
repositories to introduce a space between the words, making them easier
to read.

Motivation and Context

To make our labels more readable, as well as after discussion with @gep13 it was decided that it would be better to add spaces, than add additional configurations to repositories behaving differently.

Testing

Not possibly to test until changes are merged in to a synchronized repository.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

N/A

This updates the common labels that is synchronized to different
repositories to introduce a space between the words, making them easier
to read.
@AdmiringWorm AdmiringWorm self-assigned this Sep 23, 2024
@AdmiringWorm AdmiringWorm requested review from gep13 and pauby September 23, 2024 12:46
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Sep 23, 2024

@pauby had a chat with @AdmiringWorm and confirmed that as long as the alias is added, the result should be a rename of a label, rather than a deletion. So going to move forward with merging this.

@gep13 gep13 merged commit a5439c9 into chocolatey:main Sep 23, 2024
@AdmiringWorm AdmiringWorm deleted the label-update branch November 29, 2024 22:32
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants