Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(scribus) Migrated to AU #709

Merged
merged 3 commits into from
Apr 29, 2017
Merged

(scribus) Migrated to AU #709

merged 3 commits into from
Apr 29, 2017

Conversation

AdmiringWorm
Copy link
Member

No description provided.

@AdmiringWorm AdmiringWorm requested review from gep13 and TomOne April 28, 2017 19:19
@AdmiringWorm AdmiringWorm mentioned this pull request Apr 28, 2017
19 tasks
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor question.

fileType = 'exe'
file = "$toolsPath\scribus-1.4.6-windows.exe"
file64 = "$toolsPath\scribus-1.4.6-windows-x64.exe"
softwareName = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something to put in here? Or should it be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ops, yeah something is supposed to go there.
I must have just forgotten about it.
That's what I get for working on multiple packages at the same time. XD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdmiringWorm ha ha, not a problem 👍

@AdmiringWorm
Copy link
Member Author

I'm updating this with the softwareName tomorrow, I'm more or less about to sign of for today.

@AdmiringWorm
Copy link
Member Author

@gep13 just added the missing softwareName.
Just waiting for the appveyor build to run, then I'll merge this one.

@AdmiringWorm AdmiringWorm merged commit 528136a into master Apr 29, 2017
@AdmiringWorm AdmiringWorm deleted the scribus branch April 29, 2017 09:12
@AdmiringWorm
Copy link
Member Author

AdmiringWorm commented Apr 29, 2017

Damn, didn't notice that the archive became too large.
I'll need to rework it by downloading the files
The archive became around 19 MB too large XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants