-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(scribus) Migrated to AU #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one minor question.
fileType = 'exe' | ||
file = "$toolsPath\scribus-1.4.6-windows.exe" | ||
file64 = "$toolsPath\scribus-1.4.6-windows-x64.exe" | ||
softwareName = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something to put in here? Or should it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ops, yeah something is supposed to go there.
I must have just forgotten about it.
That's what I get for working on multiple packages at the same time. XD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdmiringWorm ha ha, not a problem 👍
I'm updating this with the softwareName tomorrow, I'm more or less about to sign of for today. |
@gep13 just added the missing softwareName. |
Damn, didn't notice that the archive became too large. |
No description provided.