-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(scite4autohotkey) Modernized package #708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@majkinetor I don't suppose you have any suggestions to the autohotkey uninstall script. |
I know it works, but I think it could be better |
3a22ef9
to
b345910
Compare
Yeah, it could be better. That sleep can cause it to fail in some cases because something else can hijack active window. But, I don't think this package will see that many users so its best not to waste time perfecting its installer for the moment (unless somebody complains). |
Yeah, I figured as much. Hence why I already merged it. |
You could look for:
etc. The problem is not that, its that Send is non window specific. It just sends the keys. Its better to use With sending you might want to use BlockInput to make it more bulletproof although it doesn't guarantee 100% - 3td party window may programatically steal focus. |
@majkinetor thanks, I'll keep that in mind for the next time I need to look into using autohotkey. |
In this case its probably the best to change original install.ahk instead of driving it via another ahk |
No description provided.