Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(scite4autohotkey) Modernized package #708

Merged
merged 2 commits into from
Apr 28, 2017
Merged

Conversation

AdmiringWorm
Copy link
Member

No description provided.

Copy link
Contributor

@majkinetor majkinetor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@AdmiringWorm
Copy link
Member Author

@majkinetor I don't suppose you have any suggestions to the autohotkey uninstall script.
I have no knowledge regarding autohotkey, so it's the best I could manage without some feedback.

@AdmiringWorm
Copy link
Member Author

I know it works, but I think it could be better

@AdmiringWorm AdmiringWorm merged commit 636ffcf into master Apr 28, 2017
@AdmiringWorm AdmiringWorm deleted the scite4autohotkey branch April 28, 2017 19:50
@majkinetor
Copy link
Contributor

Yeah, it could be better. That sleep can cause it to fail in some cases because something else can hijack active window.

But, I don't think this package will see that many users so its best not to waste time perfecting its installer for the moment (unless somebody complains).

@AdmiringWorm
Copy link
Member Author

Yeah, I figured as much. Hence why I already merged it.
Regarding the sleep though, it was the only way I knew how to do.
Since all the pop up windows have the same information (as picked up by autohotkey), I had to wait for a small amount to let the dialog/window show, otherwise it would just try running it all on the same dialog window.

@majkinetor
Copy link
Contributor

Since all the pop up windows have the same information (as picked up by autohotkey),

You could look for:

  • all text
  • number of controls

etc.

The problem is not that, its that Send is non window specific. It just sends the keys. Its better to use ControlSend if it works, to send to specific window.

With sending you might want to use BlockInput to make it more bulletproof although it doesn't guarantee 100% - 3td party window may programatically steal focus.

@AdmiringWorm
Copy link
Member Author

@majkinetor thanks, I'll keep that in mind for the next time I need to look into using autohotkey.

@majkinetor
Copy link
Contributor

In this case its probably the best to change original install.ahk instead of driving it via another ahk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants