(OpenSSL.Light) Migrated to AU #701
Conversation
|
What is the point of lastversion ? BTW, it occurred to me that we can use similar mechanism to support multiple streams of tools (majkinetor/au#74). I.E forcing the update if specific stream is updated. The side effect would be that last version in nuspec would change but that would not damage the procedure. |
|
the point of lastversion is to store the actual version from the previous update. |
|
Yes you can. You convert letter to number and then you don't need all that mumbo jumbo:
|
|
@majkinetor I initially went that route, before I noticed the version history of OpenSSL.Light. Of course, we could pad the revision number. But that would mean we had to pad it by 9 characters which I find a little too large. |
|
@gep13 @pascalberger @ferventcoder |
There was a problem hiding this comment.
@AdmiringWorm How is it guaranteed that license.txt is persisted between build runs?
Also added some other small comments
automatic/OpenSSL.Light/update.ps1
Outdated
| if (Test-Path "$PSScriptRoot\LastVersion.txt") { | ||
| $lastVersion = Get-Content "$PSScriptRoot\LastVersion.txt" | ||
| if ($lastVersion -ne $version32) { $global:au_Force = $true } | ||
| } |
There was a problem hiding this comment.
No indentation. Code is quite hard to read this way
| <projectUrl>https://slproweb.com/products/Win32OpenSSL.html</projectUrl> | ||
| <iconUrl>https://cdn.rawgit.com/chocolatey/chocolatey-coreteampackages/ff58a020fa163df8a14004b9802a3cb455a76eac/icons/openssl.png</iconUrl> | ||
| <copyright>Ⓒ 2000-2003 Shining Light Productions</copyright> | ||
| <licenseUrl>https://www.openssl.org/source/license.html</licenseUrl> |
There was a problem hiding this comment.
Is this the correct license for the Win32 distro?
There was a problem hiding this comment.
Honestly, I don't now. I just reused the license already specified.
| <copyright>Ⓒ 2000-2003 Shining Light Productions</copyright> | ||
| <licenseUrl>https://www.openssl.org/source/license.html</licenseUrl> | ||
| <requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
| <tags>openssl-light openssl ssl tls pfx pem key rsa admin</tags> |
There was a problem hiding this comment.
Add obligatory tags as per § 1.2.2
license.txt? Or are you talking about the lastversion.txt file perhaps? |
|
@AdmiringWorm Yeah, sorry. I meant |
|
@pascalberger no when the package gets update, AU calls git on the changed files in the package directory and pushes the changes when all updates is complete. However, I'm changing this to pad the revision with '8' characters instead of using the date hack. |
AdmiringWorm
force-pushed
the
OpenSSL.Light
branch
from
f0676f5 to
f8cda90
Compare
|
@majkinetor I updated the |
|
@pascalberger any chance of an updated review? |
|
@AdmiringWorm LGTM |
No description provided.