-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notepadplusplus #321
Notepadplusplus #321
Conversation
I had to use @gep13, can you reproduce this behavior or is it location specific ? I can't figure out how to do this so far, everything I tried either downloads the entire file or doesn't work, so any help is highly appreciated. This check is very important in order not to push spoiled packages (it protects from vendor site changes). For some sites its OK to use |
silentArgs = '/S' | ||
validExitCodes = @(0) | ||
registryUninstallerKey = 'notepad\+\+' | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is almost zero need to repeat the urls and checksums, it would make more sense to push them all into the packageArgs instead of above and then just linked.
I'm assuming the regex could handle finding that properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost 0 isnt 0.
It must be se this way when u want to set url32 equal to url64 and the same for checksums.
Here it isnt mandatory but i dont like to change the template and regex just for that.
Plus, the intene is clear here .... above lines are changed by the updater, bellow lines are not.
@majkinetor yes, I am seeing the same issue with the URL Checking as you mentioned. |
Thx for verifying. So this would definitelly need to get inproved.... i have no idea why that call timesout |
This is from @ferventcoder.
I updated all 3 packages, but can't push as I am not maintainer. I will use in the future version 0.0 do denote that it is intented to run the updater.