Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notepadplusplus #321

Merged
merged 3 commits into from
Oct 10, 2016
Merged

Notepadplusplus #321

merged 3 commits into from
Oct 10, 2016

Conversation

majkinetor
Copy link
Contributor

This is from @ferventcoder.

I updated all 3 packages, but can't push as I am not maintainer. I will use in the future version 0.0 do denote that it is intented to run the updater.

@majkinetor
Copy link
Contributor Author

I had to use NoCheckUrl although I don't want to becasue my current implementation of this AU feature timeouts quite frequently. See majkinetor/au#35

@gep13, can you reproduce this behavior or is it location specific ?

I can't figure out how to do this so far, everything I tried either downloads the entire file or doesn't work, so any help is highly appreciated. This check is very important in order not to push spoiled packages (it protects from vendor site changes). For some sites its OK to use NoCheckUrl (for example FossHub).

silentArgs = '/S'
validExitCodes = @(0)
registryUninstallerKey = 'notepad\+\+'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is almost zero need to repeat the urls and checksums, it would make more sense to push them all into the packageArgs instead of above and then just linked.

I'm assuming the regex could handle finding that properly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 0 isnt 0.

It must be se this way when u want to set url32 equal to url64 and the same for checksums.

Here it isnt mandatory but i dont like to change the template and regex just for that.

Plus, the intene is clear here .... above lines are changed by the updater, bellow lines are not.

@gep13
Copy link
Member

gep13 commented Oct 10, 2016

@majkinetor yes, I am seeing the same issue with the URL Checking as you mentioned.

@gep13 gep13 merged commit a5c069e into master Oct 10, 2016
@majkinetor
Copy link
Contributor Author

@gep13

Thx for verifying. So this would definitelly need to get inproved.... i have no idea why that call timesout

@gep13 gep13 deleted the notepadplusplus branch October 10, 2016 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants