Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(inkscape) Doesn't shim CLI tool inkscape.com only inkscape.exe #1717

Closed
CAMOBAP opened this issue Sep 26, 2021 · 7 comments
Closed

(inkscape) Doesn't shim CLI tool inkscape.com only inkscape.exe #1717

CAMOBAP opened this issue Sep 26, 2021 · 7 comments

Comments

@CAMOBAP
Copy link

CAMOBAP commented Sep 26, 2021

Per https://wiki.inkscape.org/wiki/index.php?title=Frequently_asked_questions#I.27m_on_Windows.2C_and_command_line_parameters_don.27t_seem_to_work.21
inkscape's installer provide two programs:

  • inkscape.exe - GUI
  • inkscape.com - CLI

And it will be nice to have both installed

Expected Behavior

choco install inkscape should install inkscape.com

Current Behavior

choco install inkscape only install inkscape.exe

Possible Solution

Modify https://github.com/chocolatey-community/chocolatey-coreteampackages/blob/15c78b92f0e81d6d8719811e30c84064a306f98d/automatic/inkscape/tools/chocolateyInstall.ps1#L52 to install both inkscape.com and inkscape.exe

Steps to Reproduce (for bugs)

  1. choco install inkscape
  2. refreshenv
  3. inkscape -? - shows nothing

Context

Impossible to execute inkscape from CLI (cmd or PowerShell)

Your Environment

@majkinetor majkinetor changed the title inkscape package doesn't install CLI tool inkscape.com only inkscape.exe (inkscape) Doesn't install CLI tool inkscape.com only inkscape.exe Sep 26, 2021
@majkinetor majkinetor changed the title (inkscape) Doesn't install CLI tool inkscape.com only inkscape.exe (inkscape) Doesn't shim CLI tool inkscape.com only inkscape.exe Sep 26, 2021
@majkinetor
Copy link
Contributor

So it installs it, its just not shimmed. I changed the title accordingly.

I personally wouldn't like to have such pollution of my binary path. For almost all of the users there is no benefit of having them both - the difference is only that logs are visible in console AFAIK.

@CAMOBAP
Copy link
Author

CAMOBAP commented Sep 26, 2021

@majkinetor

I personally wouldn't like to have such pollution of my binary path.

Why this considering as "pollution" if it have the same name but different extensions (com vs exe), so ink scape.com will be called by default from CMD or PowerShell

the difference is only that logs are visible in console AFAIK

Not only this, if you call inkscape.exe it will finished immediately and processing will start in another process, so any software which reply on files which should be generated will not work

If there is still not enough arguments, can we consider to add install-time param to install inkscape.com if it really need

P.S. I can prepare PR

@majkinetor
Copy link
Contributor

Why this considering as "pollution"

Tab competition will suffer and .com will be listed first. Not a big deal though.

Not only this, if you call inkscape.exe it will finished immediately and processing will start in another process, so any software which reply on files which should be generated will not work

What is wrong with

Start -Wait inkscape.exe

P.S. I can prepare PR

Sure.

@CAMOBAP
Copy link
Author

CAMOBAP commented Sep 26, 2021

What is wrong with Start -Wait inkscape.exe

I can confirm that It works, but it force us to use Powershell while mosty of API to run a shell on windows uses batch/cmd out of the box. Of course, programmers can explicitly call powershell and then required command from it but... why if inkscape developers already provide a consistent official way to work with Inkscape CLI

I will prepare PR

@CAMOBAP
Copy link
Author

CAMOBAP commented Sep 27, 2021

Looks like the correct way to accomplish this is to add support for '.com' files to https://github.com/chocolatey/choco/blob/master/src/chocolatey.resources/helpers/functions/Install-BinFile.ps1

Still researching, closing PR yet

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Dear contributor,

As this issue seems to have been inactive for quite some time now, I've automatically closed it.
If you feel this is a valid issue, please feel free to re-open the issue if/when a pull request
has been added.
Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants