Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup for energy measurement (wrong type) and 2024.6 compatibility #9

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

bipsendk
Copy link
Contributor

Class for energy should not be power (it is not electricity - it is heating)
class AmphiroBluetoothSensorEntity updated in order to work with HomeAssistant build 2024.6

bipsendk added 2 commits June 17, 2024 20:12
Energy class wrong - Device class power is more suitable for electricity, here it it heating energy.
class AmphiroBluetoothSensorEntity modified to work with 2024.6
@chkuendig
Copy link
Owner

Thanks for submitting this, I'll quickly test it myself before merging, but generally this looks good!

@bipsendk
Copy link
Contributor Author

Gets these errors during pull:

validate-hacs
failed: The repository has no valid topics (More info: https://hacs.xyz/docs/publish/include#check-repository )

validate-hacs
<Integration bipsendk/hass-amphiro-ble> 1/8 checks failed

validate-hacs
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@chkuendig chkuendig linked an issue Jun 18, 2024 that may be closed by this pull request
@chkuendig
Copy link
Owner

Looks good. I made some minor adjustments to reflect this more in line with changes made to upstream (home-assistant/core@da35097 and home-assistant/core@4f4389b ).

Gets these errors during pull:
[...]

You can ignore these. They only fail on your fork as it's missing some settings for a potentitial HACS integration (and the node one is just a warning). On this repo they pass.

@chkuendig chkuendig merged commit c963481 into chkuendig:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in log using HA 2024.6.0b2
2 participants