Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified interface. #2

Merged
merged 1 commit into from
Feb 22, 2012
Merged

Simplified interface. #2

merged 1 commit into from
Feb 22, 2012

Conversation

rauchg
Copy link
Contributor

@rauchg rauchg commented Feb 22, 2012

Couldn't really test since make is failing for me right now. The idea is to be more node-like in the interface, yet still allow extensibility of the constructor/prototype if needed.

@chjj
Copy link
Owner

chjj commented Feb 22, 2012

Couldn't really test since make is failing for me right now.

What is it failing from? I've only tested the latest version on linux. It might be missing some osx specific headers.

Anyway, looks good to me. More reminiscent of child_process.spawn.

chjj added a commit that referenced this pull request Feb 22, 2012
@chjj chjj merged commit 1e0986f into chjj:master Feb 22, 2012
@rauchg
Copy link
Contributor Author

rauchg commented Feb 22, 2012

[1/2] cxx: src/pty.cc -> build/Release/src/pty_1.o
../src/pty.cc: In function ‘int pty_execvpe(const char*, char**, char**)’:
../src/pty.cc:211: error: ‘environ’ was not declared in this scope
Waf: Leaving directory `/Users/guillermorauch/Projects/pty.js/build'
Build failed:  -> task failed (err #1): 
    {task: cxx pty.cc -> pty_1.o}

terryschen pushed a commit to terryschen/pty.js that referenced this pull request May 10, 2014
check the sigchld handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants