Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for args #1

Closed
rauchg opened this issue Feb 21, 2012 · 4 comments
Closed

Support for args #1

rauchg opened this issue Feb 21, 2012 · 4 comments

Comments

@rauchg
Copy link
Contributor

rauchg commented Feb 21, 2012

Ideally the signature would be as follows

new Terminal('bash', [args], { options })
@chjj
Copy link
Owner

chjj commented Feb 21, 2012

Agreed.

It's more limited right now because it was taken directly out of tty.js, which doesn't have any need for arguments

@TooTallNate
Copy link
Collaborator

👍

@chjj
Copy link
Owner

chjj commented Feb 22, 2012

6a26a90

It has the exact same arguments as child_process.spawn now. The only difference is 3 extra options: name, cols, and rows.

@chjj chjj closed this as completed Feb 22, 2012
@rauchg
Copy link
Contributor Author

rauchg commented Feb 22, 2012

Very cool. Thanks @chjj

jaredly referenced this issue in jaredly/pty.js Aug 5, 2013
Merge pull request niallo#1 from jaredly/master
46e9ed3 
fixing interoperability with native child_process. also added tests
ddm pushed a commit to ddm/pty.js that referenced this issue Nov 8, 2017
@Tyriar
Merge pull request chjj#1 from Tyriar/test-the-ress-fixes
e427816
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rauchg @TooTallNate @chjj