Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2TLB never reads after writing #2601

Merged
merged 1 commit into from
Aug 13, 2020
Merged

L2TLB never reads after writing #2601

merged 1 commit into from
Aug 13, 2020

Conversation

ingallsj
Copy link
Contributor

@ingallsj ingallsj commented Aug 13, 2020

Type of change: bug report

Impact: performance improvement, no functional change

Development Phase: implementation

Release Notes
This only affects designs with MMU and clock gating.

The bug is that an L2TLB write will almost always block the next L2TLB search, even many cycles later, because the l2_refill register doesn't clear until the next search enables the clock.

We can break out of this loop if we get lucky, if a request from the other L1TLB will enable the clock with arb.io.out.valid, or a PTW will not allocate the L2TLB (i.e. a superpage or a faulty translation), or an SFENCE will enable the clock with io.dpath.sfence.valid.

The fix is to add the l2_refill register to ptw_clock_en.

customCSRs.disableDCacheClockGate is a work-around to utilize the L2TLB at the cost of extra power.

@ingallsj ingallsj added the bug label Aug 13, 2020
@ingallsj ingallsj requested a review from aswaterman August 13, 2020 00:40
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ingallsj ingallsj merged commit b90ea84 into master Aug 13, 2020
@ingallsj ingallsj deleted the ptw_l2_refill branch August 13, 2020 04:16
@ingallsj ingallsj changed the title PTW clock_en l2_refill L2TLB never reads after writing Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants