Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: bug report
Impact: performance improvement, no functional change
Development Phase: implementation
Release Notes
This only affects designs with MMU and clock gating.
The bug is that an L2TLB write will almost always block the next L2TLB search, even many cycles later, because the
l2_refill
register doesn't clear until the next search enables the clock.We can break out of this loop if we get lucky, if a request from the other L1TLB will enable the clock with
arb.io.out.valid
, or a PTW will not allocate the L2TLB (i.e. a superpage or a faulty translation), or an SFENCE will enable the clock withio.dpath.sfence.valid
.The fix is to add the
l2_refill
register toptw_clock_en
.customCSRs.disableDCacheClockGate
is a work-around to utilize the L2TLB at the cost of extra power.