-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port LazyRoCC examples to chisel3 #2553
Conversation
Convert LazyRoCC examples to use chisel3 syntax instead of legacy Chisel compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @kammoh! Generally, looks fine. Comments inline.
By chance have you tested this with any RoCCs? (By inspection, I see no issues.)
Co-authored-by: Schuyler Eldridge <[email protected]>
Co-authored-by: Schuyler Eldridge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@hcook: I'll leave the merging to you.
@hcook is there anything you'd like me to change here? |
Convert LazyRoCC examples to use chisel3 syntax instead of legacy Chisel compatibility.
Related issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes