Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port LazyRoCC examples to chisel3 #2553

Merged
merged 7 commits into from
Jul 31, 2020
Merged

Conversation

kammoh
Copy link
Contributor

@kammoh kammoh commented Jul 12, 2020

Convert LazyRoCC examples to use chisel3 syntax instead of legacy Chisel compatibility.

Related issue:

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

kammoh added 3 commits July 12, 2020 16:53
Convert LazyRoCC examples to use chisel3 syntax instead of legacy Chisel compatibility.
@hcook hcook requested review from hcook and seldridge July 13, 2020 17:36
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @kammoh! Generally, looks fine. Comments inline.

By chance have you tested this with any RoCCs? (By inspection, I see no issues.)

src/main/scala/tile/LazyRoCC.scala Outdated Show resolved Hide resolved
src/main/scala/tile/LazyRoCC.scala Outdated Show resolved Hide resolved
src/main/scala/tile/LazyRoCC.scala Show resolved Hide resolved
kammoh and others added 2 commits July 13, 2020 16:58
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hcook: I'll leave the merging to you.

@kammoh
Copy link
Contributor Author

kammoh commented Jul 31, 2020

@hcook is there anything you'd like me to change here?

@jackkoenig jackkoenig merged commit bf07585 into chipsalliance:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants