Bundle Bridge Tile MMIO Address Prefix #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcook
force-pushed
the
bundle-bridge-tile-local-address-prefix
branch
from
69170d4 to
938c633
Compare
hcook
force-pushed
the
bundle-bridge-tile-local-address-prefix
branch
from
938c633 to
7618777
Compare
aswaterman
approved these changes
Jun 25, 2020
mwachs5
reviewed
Jun 25, 2020
mwachs5
reviewed
Jun 25, 2020
mwachs5
reviewed
Jun 25, 2020
hcook
force-pushed
the
bundle-bridge-tile-local-address-prefix
branch
from
99b6fd8 to
d68e791
Compare
mwachs5
approved these changes
Jun 29, 2020
…o locate driver of tile.controlAddressPrefixNode
…kNodeOpt and use their .map(_.bundle) in TIM base address calculation
Co-authored-by: Megan Wachs <[email protected]>
hcook
force-pushed
the
bundle-bridge-tile-local-address-prefix
branch
from
d68e791 to
1cd3592
Compare
This was referenced Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some configurations we want to be able to relocate the apparent base address of MMIO devices inside the tile. This is problematic for the fast path that the RocketCore has to the ITIM and DTIM, which has to know what the overridden base address should be. To address this limitation this PR adds another (optional) tile input "constant" that is or'd with the base address used in the ITIM and DTIM hit calculations.
This PR also cleans up a few loose ends left over from #2521 and #2497
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
Release Notes
BaseTile.mmioAddressPrefixNodepropagates a prefix or supplies a default0.UTileCrossingParamsLike.controlBaseAddressPrefixWhereto lookup prefix information location for tilesmmioAddressPrefixSinkNodeOptandhartIdSinkNodeOptinHellaCacheandICache, defined iff the scratchpads areTLBusWrappersubclasses will propagate theirprefixinformation