AsyncQueue: Convert AsyncValidSync to RawModule #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernie-sifive
approved these changes
Mar 21, 2020
mwachs5
added a commit
that referenced
this pull request
Mar 26, 2020
…id-sync-as-raw-module"" This reverts commit 4cc8686.
jackkoenig
added a commit
that referenced
this pull request
Mar 27, 2020
Revert "Revert "Merge pull request #2352"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: None
Type of change: bug report
Impact: API modification
Development Phase: implementation
Release Notes
The AsyncValidSync inside AsyncCrossing is now a RawModule, not a Module. It still has two IO/s (clock and reset) but these need to be explicitly assigned.
The reason for this behavior is to allow AsyncCrossing to work across a mixture of reset schemes.