Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Deprecate BlackBoxResourceAnno #2262

Merged
merged 3 commits into from
Jul 11, 2021

Conversation

seldridge
Copy link
Member

@seldridge seldridge commented Jun 7, 2021

Companion PR to chipsalliance/chisel#1954.

This deprecates BlackBoxResourceAnno. It's a weird API that requires finding a Java Resource. This is a weird thing to make a part of the Annotations API where the Java Resource API is effectively needed to implement a FIRRTL compiler. BlackBoxResourceAnno can be fully removed by resolving a resource during Chisel elaboration (what chipsalliance/chisel#1954 does).

Signed-off-by: Schuyler Eldridge [email protected]

Contributor Checklist

  • [n/a] Did you add Scaladoc to every public function/method?
  • [n/a] Did you update the FIRRTL spec to include every new feature/behavior?
  • [n/a] Did you add at least one test demonstrating the PR?
  • [n/a] Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API deprecation

API Impact

Deprecates BlackBoxResourceAnno.

Backend Code Generation Impact

None.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Signed-off-by: Schuyler Eldridge <[email protected]>
@seldridge seldridge added this to the 1.5.0 milestone Jun 8, 2021
@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jul 11, 2021
@mergify mergify bot merged commit 315f3c8 into master Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants