add back execute(optionsManager, dut) for chisel-dsp. #1852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1731, I removed the
Driver.execute
blindly, but I found the path is a little steep for legacyOptionsManager
codes, this PR adds backexecute(optiionsManager, dut)
back tochisel3.stage.Stage
to make chisel-dsp be able to compile, and deprecate this API, making the deprecation path smoother.Contributor Checklist
docs/src
?Type of Improvement
API Impact
add
chisel3.stage.chiselStage.execute(optionsManager: ExecutionOptionsManager with HasChiselExecutionOptions with HasFirrtlOptions, dut: () => RawModule)
Backend Code Generation Impact
none
Desired Merge Strategy
Release Notes
add and deprecate API:
chisel3.stage.chiselStage.execute
Reviewer Checklist (only modified by reviewer)
Please Merge
?