Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toString method to BitPat #1819

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Add toString method to BitPat #1819

merged 2 commits into from
Mar 18, 2021

Conversation

yqszxx
Copy link
Contributor

@yqszxx yqszxx commented Mar 18, 2021

Required by util.experimental.decoder (WIP, new name is util.experimental.minimizer). Use the string representation of BitPat as key of the cache map to provide reusability when generating minimized logic.
And also useful for normal usages.

Contributor Checklist

  • Did you add Scaladoc to every public function/method? N/A
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src? N/A
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • new feature

API Impact

Add toString method to BitPat

Backend Code Generation Impact

No

Desired Merge Strategy

  • Squash: The PR will be squashed and merged.

Release Notes

BitPat can now produce meaningful string representation.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig jackkoenig added this to the 3.4.x milestone Mar 18, 2021
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Mar 18, 2021
@mergify mergify bot merged commit 2a56c65 into chipsalliance:master Mar 18, 2021
mergify bot pushed a commit that referenced this pull request Mar 18, 2021
@yqszxx
Add toString method to BitPat (#1819)
be93c02 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 2a56c65)

# Conflicts:
#	src/main/scala/chisel3/util/BitPat.scala
@mergify mergify bot mentioned this pull request Mar 18, 2021
Closed
@mergify mergify bot added the Backported This PR has been backported label Mar 18, 2021
@yqszxx yqszxx deleted the bitpat-tostring branch March 19, 2021 00:12
yqszxx added a commit to yqszxx/chisel3 that referenced this pull request Apr 11, 2021
@yqszxx @mergify
Add toString method to BitPat (chipsalliance#1819)
5a03ba8 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sequencer pushed a commit that referenced this pull request May 5, 2021
@yqszxx @mergify @sequencer
Add toString method to BitPat (#1819)
6764047 
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@sequencer sequencer mentioned this pull request May 25, 2021
Merged
14 tasks
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sequencer sequencer sequencer approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@yqszxx @sequencer @jackkoenig