Switch to using Github Actions CI #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekiwi
reviewed
Dec 3, 2020
|
Anyway, this experiment seems to have been successful. It has the same problem as we have in chisel-testers2 where caching of downloaded dependencies doesn't quite seem to be working, but it is fast enough it isn't a huge issue. |
jackkoenig
force-pushed
the
switch-to-github-actions
branch
from
0ef38e5 to
f18575a
Compare
MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x
jackkoenig
force-pushed
the
switch-to-github-actions
branch
from
f18575a to
8b8f38a
Compare
|
@ekiwi @chick This is ready to go. When we delete This will conflict upon backporting with the |
ekiwi
added
the
Please Merge
|
@Mergifyio backport 3.4.x 3.3.x 3.2.x |
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2020
MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x (cherry picked from commit 25a417f) # Conflicts: # .mergify.yml # build.sbt # project/plugins.sbt
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2020
MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x (cherry picked from commit 25a417f) # Conflicts: # .mergify.yml # build.sbt # project/plugins.sbt
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2020
MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x (cherry picked from commit 25a417f) # Conflicts: # .mergify.yml # build.sbt # project/plugins.sbt
|
Command
|
jackkoenig
added a commit
that referenced
this pull request
Dec 17, 2020
* Switch to using Github Actions CI (#1690) MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x (cherry picked from commit 25a417f) # Conflicts: # .mergify.yml # build.sbt # project/plugins.sbt * Resolve merge conflicts Co-authored-by: Jack Koenig <[email protected]>
jackkoenig
added a commit
that referenced
this pull request
Dec 17, 2020
* Switch to using Github Actions CI (#1690) MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x (cherry picked from commit 25a417f) # Conflicts: # .mergify.yml # build.sbt # project/plugins.sbt * Resolve merge conflicts * Remove mdoc check from GithubActions This test was added in 3.4 Co-authored-by: Jack Koenig <[email protected]>
jackkoenig
added a commit
that referenced
this pull request
Dec 17, 2020
* Switch to using Github Actions CI (#1690) MiMa binary compatibility checks are now run on master, but the mimaPreviousArtifacts are empty which makes the check a no-op. This helps keep both the build.sbt and CI more consistent between master and stable branches. .mergify.yml is also updated with mergify.sc from chisel-repo-tools using the following configuration: conditions: - status-success=all tests passed branches: - 3.2.x - 3.3.x - 3.4.x (cherry picked from commit 25a417f) # Conflicts: # .mergify.yml # build.sbt # project/plugins.sbt * Resolve merge conflicts and remove docs tests Docs tests were added in 3.4 Co-authored-by: Jack Koenig <[email protected]>
13 tasks
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
This should speed up the common case as the compiler never operates on the unescaped string. The new escape function also fixes a bug where ']' was not escaped even though it is the delimiting character for FileInfo. In order to maintain backwards compatibility for the ProtoBuf format, this patch adds escape/unescape calls when going from/to protobuf format. For better performance we should consider changing the protobuf format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WIP,this is partially in the interest of reducing the number of CI vendors for Chisel Working Group Projects. Once this is done we can turn on auto publishing of SNAPSHOTs as in chipsalliance/treadle#277Notably, this no longer builds dependencies (
firrtlandtreadle) from source. Those projects publish up-to-dateSNAPSHOTs on every push to a release branch and master, so there's no need to build them.Contributor Checklist
docs/src?Type of Improvement
API Impact
No impact
Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
Please Merge?